fix mapping keys when replacing data #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iuwqyir
changed the base branch from
05-14-handle_clickhouse_errors_during_inserts
to
graphite-base/196
iuwqyir
force-pushed
the
05-15-fix_mapping_keys_when_replacing_data
branch
from
0de130e to
8dbd642
Compare
iuwqyir
force-pushed
the
05-15-fix_mapping_keys_when_replacing_data
branch
from
8dbd642 to
10f868f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Changed the map key type in
ReplaceBlockDatafrom*big.Inttostringto fix potential memory issues.What changed?
Modified the
deletedBlockDataByNumbermap in theReplaceBlockDatafunction to use string keys instead of*big.Intpointers. All map operations now convert the block numbers to strings using the.String()method before using them as keys.How to test?
ReplaceBlockDatafunctionWhy make this change?
Using
*big.Intas map keys can lead to unexpected behavior because equality for pointers is based on memory address, not the actual numeric value. Two different*big.Intpointers with the same numeric value would be treated as different keys. Converting to strings ensures that blocks with the same number are properly identified and handled, preventing potential data inconsistencies and memory issues.