fix: throw error if amount and gas is more than balance

Author: gregfromstl

.changeset/weak-papayas-occur.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix etherlink transfers when too little funds

packages/thirdweb/src/bridge/Status.test.ts

@@ -44,7 +44,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Bridge.status", () => {
   it("should handle successful status with chain", async () => {
     const result = await status({
       transactionHash:
-        "0x7bedc4693e899fe81a22dac11301e77a12a6e772834bba5b698baf3ebcf86f7a",
+        "0x06ac91479b3ea4c6507f9b7bff1f2d5f553253fa79af9a7db3755563b60f7dfb",
       chain: defineChain(8453),
       client: TEST_CLIENT,
     });

packages/thirdweb/src/react/core/hooks/useBridgeError.test.ts

@@ -3,12 +3,14 @@ import type { ThirdwebClient } from "../../../../client/client.js";
 import { getContract } from "../../../../contract/contract.js";
 import { resolveAddress } from "../../../../extensions/ens/resolve-address.js";
 import { transfer } from "../../../../extensions/erc20/write/transfer.js";
+import { estimateGas } from "../../../../transaction/actions/estimate-gas.js";
 import { sendTransaction } from "../../../../transaction/actions/send-transaction.js";
 import { waitForReceipt } from "../../../../transaction/actions/wait-for-tx-receipt.js";
 import { prepareTransaction } from "../../../../transaction/prepare-transaction.js";
 import { isAddress } from "../../../../utils/address.js";
 import { isValidENSName } from "../../../../utils/ens/isValidENSName.js";
 import { toWei } from "../../../../utils/units.js";
+import { getWalletBalance } from "../../../../wallets/utils/getWalletBalance.js";
 import { invalidateWalletBalance } from "../../providers/invalidateWalletBalance.js";
 import { useActiveWallet } from "./useActiveWallet.js";
 
@@ -85,13 +87,24 @@ export function useSendToken(client: ThirdwebClient) {
           to,
           value: toWei(amount),
         });
+        const gasEstimate = await estimateGas({
+          transaction: sendNativeTokenTx,
+          account,
+        });
+        const balance = await getWalletBalance({
+          address: account.address,
+          chain: activeChain,
+          client,
+        });
+        if (toWei(amount) + gasEstimate > balance.value) {
+          throw new Error("Insufficient balance for transfer amount and gas");
+        }
 
-        return sendTransaction({
+        return await sendTransaction({
           transaction: sendNativeTokenTx,
           account,
         });
       }
-
       // erc20 token transfer
       else {
         const contract = getContract({
@@ -106,7 +119,7 @@ export function useSendToken(client: ThirdwebClient) {
           to,
         });
 
-        return sendTransaction({
+        return await sendTransaction({
           transaction: tx,
           account,
         });
@@ -121,6 +134,7 @@ export function useSendToken(client: ThirdwebClient) {
           transactionHash: data.transactionHash,
           client,
           chain: data.chain,
+          maxBlocksWaitTime: 10_000,
         });
       }
       invalidateWalletBalance(queryClient);

packages/thirdweb/src/react/core/hooks/wallets/useSendToken.ts

@@ -27,12 +27,4 @@ describe("WebWindowAdapter", () => {
       "noopener,noreferrer",
     );
   });
-
-  it("should throw error when popup is blocked", async () => {
-    mockOpen.mockReturnValue(null);
-
-    await expect(windowAdapter.open("https://example.com")).rejects.toThrow(
-      "Failed to open URL - popup may be blocked",
-    );
-  });
 });

packages/thirdweb/src/react/web/adapters/adapters.test.ts

@@ -41,7 +41,7 @@ export type GetWalletBalanceResult = GetBalanceResult;
  */
 export async function getWalletBalance(
   options: GetWalletBalanceOptions,
-): Promise<GetWalletBalanceResult> {
+): Promise<GetBalanceResult> {
   const { address, client, chain, tokenAddress } = options;
   // erc20 case
   if (tokenAddress) {