[SDK] fix: Handle authorizationList tx prop in ethers5 adapter (#6447)

Author: joaquim-verges

.changeset/true-actors-agree.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix ethers5 adapter not handling authorizationList tx prop

packages/thirdweb/src/adapters/ethers5.test.ts

@@ -7,6 +7,8 @@ import { TEST_CLIENT } from "../../test/src/test-clients.js";
 import { ANVIL_PKEY_A, TEST_ACCOUNT_B } from "../../test/src/test-wallets.js";
 import { resolveContractAbi } from "../contract/actions/resolve-abi.js";
 import { decimals } from "../extensions/erc20/__generated__/IERC20/read/decimals.js";
+import { sendTransaction } from "../transaction/actions/send-transaction.js";
+import { prepareTransaction } from "../transaction/prepare-transaction.js";
 import { randomBytesBuffer } from "../utils/random.js";
 import { privateKeyToAccount } from "../wallets/private-key.js";
 import {
@@ -209,6 +211,25 @@ describe("fromEthersSigner", () => {
     expect(signedTransaction).toBe(await wallet.signTransaction(transaction));
   });
 
+  it("should send a transaction", async () => {
+    const wallet = new ethers5.Wallet(
+      ANVIL_PKEY_A,
+      ethers5.getDefaultProvider(ANVIL_CHAIN.rpc),
+    );
+    const account = await fromEthersSigner(wallet);
+
+    const transaction = prepareTransaction({
+      client: TEST_CLIENT,
+      chain: ANVIL_CHAIN,
+      to: TEST_ACCOUNT_B.address,
+      value: 1n,
+    });
+
+    const txResponse = await sendTransaction({ transaction, account });
+
+    expect(txResponse.transactionHash.length).toBe(66);
+  });
+
   it("should sign typed data", async () => {
     const wallet = new ethers5.Wallet(ANVIL_PKEY_A);
     const account = await fromEthersSigner(wallet);

packages/thirdweb/src/adapters/ethers5.ts

@@ -624,6 +624,9 @@ function alignTxToEthers(
     }
   }
 
+  // biome-ignore lint/performance/noDelete: ethers5 doesn't support authorizationList
+  delete rest.authorizationList;
+
   return {
     ...rest,
     gasLimit: gas,

packages/thirdweb/src/adapters/ethers6.test.ts

@@ -1,11 +1,13 @@
 import * as ethers6 from "ethers6";
-import { describe, expect, test } from "vitest";
+import { describe, expect, it, test } from "vitest";
 import { ANVIL_CHAIN } from "../../test/src/chains.js";
 import { TEST_CLIENT } from "../../test/src/test-clients.js";
 import { ANVIL_PKEY_A, TEST_ACCOUNT_B } from "../../test/src/test-wallets.js";
+import { sendTransaction } from "../transaction/actions/send-transaction.js";
+import { prepareTransaction } from "../transaction/prepare-transaction.js";
 import { randomBytesBuffer } from "../utils/random.js";
 import { privateKeyToAccount } from "../wallets/private-key.js";
-import { toEthersSigner } from "./ethers6.js";
+import { fromEthersSigner, toEthersSigner } from "./ethers6.js";
 
 const account = privateKeyToAccount({
   privateKey: ANVIL_PKEY_A,
@@ -14,12 +16,7 @@ const account = privateKeyToAccount({
 
 describe("toEthersSigner", () => {
   test("should return an ethers 6 signer", async () => {
-    const signer = await toEthersSigner(
-      ethers6,
-      TEST_CLIENT,
-      account,
-      ANVIL_CHAIN,
-    );
+    const signer = toEthersSigner(ethers6, TEST_CLIENT, account, ANVIL_CHAIN);
     expect(signer).toBeDefined();
     expect(signer.signMessage).toBeDefined();
   });
@@ -40,12 +37,7 @@ describe("toEthersSigner", () => {
   });
 
   test("should sign typed data", async () => {
-    const signer = await toEthersSigner(
-      ethers6,
-      TEST_CLIENT,
-      account,
-      ANVIL_CHAIN,
-    );
+    const signer = toEthersSigner(ethers6, TEST_CLIENT, account, ANVIL_CHAIN);
     expect(signer.signTypedData).toBeDefined();
 
     // All properties on a domain are optional
@@ -88,16 +80,100 @@ describe("toEthersSigner", () => {
   });
 
   test("should send a tx", async () => {
-    const signer = await toEthersSigner(
-      ethers6,
-      TEST_CLIENT,
-      account,
-      ANVIL_CHAIN,
-    );
+    const signer = toEthersSigner(ethers6, TEST_CLIENT, account, ANVIL_CHAIN);
     const txResponse = await signer.sendTransaction({
       to: TEST_ACCOUNT_B.address,
       value: 100,
     });
     expect(txResponse.hash.length).toBe(66);
   });
 });
+
+describe("fromEthersSigner", () => {
+  it("should convert an ethers6 Signer to an Account", async () => {
+    const wallet = new ethers6.Wallet(ANVIL_PKEY_A);
+    const account = await fromEthersSigner(wallet);
+
+    expect(account).toBeDefined();
+    expect(account.address).toBe(await wallet.getAddress());
+  });
+
+  it("should sign a message", async () => {
+    const wallet = new ethers6.Wallet(ANVIL_PKEY_A);
+    const account = await fromEthersSigner(wallet);
+
+    const message = "Hello, world!";
+    const signature = await account.signMessage({ message });
+
+    expect(signature).toBe(await wallet.signMessage(message));
+  });
+
+  it("should sign a transaction", async () => {
+    const wallet = new ethers6.Wallet(
+      ANVIL_PKEY_A,
+      ethers6.getDefaultProvider(),
+    );
+    const account = await fromEthersSigner(wallet);
+
+    const transaction = {
+      to: "0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC",
+      value: 1n,
+    };
+
+    const signedTransaction = await account.signTransaction?.(transaction);
+
+    expect(signedTransaction).toBe(await wallet.signTransaction(transaction));
+  });
+
+  it("should send a transaction", async () => {
+    const wallet = new ethers6.Wallet(
+      ANVIL_PKEY_A,
+      ethers6.getDefaultProvider(ANVIL_CHAIN.rpc),
+    );
+    const account = await fromEthersSigner(wallet);
+
+    const transaction = prepareTransaction({
+      client: TEST_CLIENT,
+      chain: ANVIL_CHAIN,
+      to: TEST_ACCOUNT_B.address,
+      value: 1n,
+    });
+
+    const txResponse = await sendTransaction({ transaction, account });
+
+    expect(txResponse.transactionHash.length).toBe(66);
+  });
+
+  it("should sign typed data", async () => {
+    const wallet = new ethers6.Wallet(ANVIL_PKEY_A);
+    const account = await fromEthersSigner(wallet);
+
+    const domain = {
+      name: "Ether Mail",
+      version: "1",
+      chainId: 1,
+      verifyingContract: "0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC",
+    };
+
+    const types = {
+      Person: [
+        { name: "name", type: "string" },
+        { name: "wallet", type: "address" },
+      ],
+    };
+
+    const value = {
+      name: "Alice",
+      wallet: "0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC",
+    };
+
+    const signature = await account.signTypedData({
+      primaryType: "Person",
+      domain,
+      types,
+      message: value,
+    });
+
+    expect(signature).toBeDefined();
+  });
+});