update

Author: kien-ngo

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/platform-fees.tsx

@@ -36,7 +36,7 @@ const CommonPlatformFeeSchema = z.object({
   /**
    * platform fee basis points
    */
-  platform_fee_basis_points: BasisPointsSchema.default(0),
+  platform_fee_basis_points: BasisPointsSchema,
   /**
    * platform fee recipient address
    */
@@ -84,11 +84,6 @@ export const SettingsPlatformFees = ({
             action: "set-platform-fees",
             label: "attempt",
           });
-          // In the v4 hook we defaulted recipient to address_zero and bps to `0`
-          // but let's actually throw an error here for better transparency
-          if (!data.platform_fee_basis_points) {
-            return toast.error("Please enter valid basis points.");
-          }
           if (!data.platform_fee_recipient) {
             return toast.error("Please enter a valid platform fee recipient.");
           }

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/royalties.tsx

@@ -46,7 +46,7 @@ const CommonRoyaltySchema = z.object({
    * @internal
    * @remarks used by OpenSea "seller_fee_basis_points"
    */
-  seller_fee_basis_points: BasisPointsSchema.default(0),
+  seller_fee_basis_points: BasisPointsSchema,
 
   /**
    * The address of the royalty recipient. All royalties will be sent
@@ -97,11 +97,6 @@ export const SettingsRoyalties = ({
             action: "set-royalty",
             label: "attempt",
           });
-          // In the v4 hook we defaulted recipient to address_zero and bps to `0`
-          // but let's actually throw an error here for better transparency
-          if (!d.seller_fee_basis_points) {
-            return toast.error("Please enter valid basis points.");
-          }
           if (!d.fee_recipient) {
             return toast.error("Please enter a valid royalty fee recipient.");
           }