refactor: simplify API fetch error handling in aa-chains route

Author: joaquim-verges

apps/portal/src/app/api/aa-chains/route.ts

@@ -9,28 +9,38 @@ type ApiResponseType = {
 };
 
 export async function GET() {
-  const [chainsWithServices, allChains] = await Promise.all([
-    fetch("https://api.thirdweb.com/v1/chains/services", {
+  const chainsWithServicesResponse = await fetch(
+    "https://api.thirdweb.com/v1/chains/services",
+    {
       headers: {
         "Content-Type": "application/json",
       },
-    })
-      .then((res) => res.json() as Promise<ApiResponseType>)
-      .catch((error) => {
-        console.error(error);
-        return { data: {} as ApiResponseType["data"] };
-      }),
-    fetch("https://api.thirdweb.com/v1/chains", {
-      headers: {
-        "Content-Type": "application/json",
-      },
-    })
-      .then((res) => res.json() as Promise<{ data: ChainMetadata[] }>)
-      .catch((error) => {
-        console.error(error);
-        return { data: [] as ChainMetadata[] };
-      }),
-  ]);
+    },
+  );
+
+  if (!chainsWithServicesResponse.ok) {
+    throw new Error(
+      `Failed to fetch chains with services ${chainsWithServicesResponse.status} - ${chainsWithServicesResponse.statusText}`,
+    );
+  }
+
+  const allChainsResponse = await fetch("https://api.thirdweb.com/v1/chains", {
+    headers: {
+      "Content-Type": "application/json",
+    },
+  });
+
+  if (!allChainsResponse.ok) {
+    throw new Error(
+      `Failed to fetch all chains ${allChainsResponse.status} - ${allChainsResponse.statusText}`,
+    );
+  }
+
+  const chainsWithServices =
+    (await chainsWithServicesResponse.json()) as ApiResponseType;
+  const allChains = (await allChainsResponse.json()) as {
+    data: ChainMetadata[];
+  };
 
   const aaChains = Object.entries(chainsWithServices.data)
     .filter(([, services]) =>

apps/portal/src/components/Document/AAChainList.tsx

@@ -7,12 +7,13 @@ async function getChains(): Promise<ChainMetadata[]> {
   try {
     const chains = await fetch(`${getBaseUrl()}/api/aa-chains`);
     if (!chains.ok) {
+      console.error("Failed to fetch chains", chains.statusText);
       return [];
     }
     const result = (await chains.json()) as { data: ChainMetadata[] };
     return result.data;
   } catch (error) {
-    console.error(error);
+    console.error("Failed to fetch chains", error);
     return [];
   }
 }