Commit 2c43c64
committed
fix: defaultChainId should be validated in
https://linear.app/thirdweb/issue/DASH-546/can-not-update-ecosystem-settings-form-if-default-chain-id-is-not-set
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving the `update-partner-modal.client.tsx` and `auth-options-form.client.tsx` components by modifying the `DialogTrigger` and enhancing validation logic for the `defaultChainId` field.
### Detailed summary
- Changed `DialogTrigger` to use `asChild` prop in `update-partner-modal.client.tsx`.
- Made `defaultChainId` optional and adjusted its validation error handling in `auth-options-form.client.tsx`.
- Added a new refinement rule to validate `defaultChainId` based on `useSmartAccount`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->refine (#5638)1 parent b2b95a5 commit 2c43c64
File tree
2 files changed
+18
-4
lines changed- apps/dashboard/src/app/team/[team_slug]/(team)/~/ecosystem/[slug]/(active)/configuration/components/client
2 files changed
+18
-4
lines changedLines changed: 17 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| |||
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
111 | 125 | | |
112 | 126 | | |
113 | 127 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments