feat(sdk): adds ox for bytes and hex utils

Author: gregfromstl

.changeset/nice-gifts-argue.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Adds ox for internal utilities

packages/thirdweb/.size-limit.json

@@ -2,7 +2,7 @@
   {
     "name": "thirdweb (esm)",
     "path": "./dist/esm/exports/thirdweb.js",
-    "limit": "45 kB",
+    "limit": "50 kB",
     "import": "*"
   },
   {
@@ -13,7 +13,7 @@
   {
     "name": "thirdweb (minimal + tree-shaking)",
     "path": "./dist/esm/exports/thirdweb.js",
-    "limit": "5 kB",
+    "limit": "7.5 kB",
     "import": "{ createThirdwebClient, getRpcClient, defineChain }"
   },
   {

packages/thirdweb/package.json

@@ -127,60 +127,24 @@
   },
   "typesVersions": {
     "*": {
-      "adapters/*": [
-        "./dist/types/exports/adapters/*.d.ts"
-      ],
-      "auth": [
-        "./dist/types/exports/auth.d.ts"
-      ],
-      "chains": [
-        "./dist/types/exports/chains.d.ts"
-      ],
-      "contract": [
-        "./dist/types/exports/contract.d.ts"
-      ],
-      "deploys": [
-        "./dist/types/exports/deploys.d.ts"
-      ],
-      "event": [
-        "./dist/types/exports/event.d.ts"
-      ],
-      "extensions/*": [
-        "./dist/types/exports/extensions/*.d.ts"
-      ],
-      "pay": [
-        "./dist/types/exports/pay.d.ts"
-      ],
-      "react": [
-        "./dist/types/exports/react.d.ts"
-      ],
-      "react-native": [
-        "./dist/types/exports/react-native.d.ts"
-      ],
-      "rpc": [
-        "./dist/types/exports/rpc.d.ts"
-      ],
-      "storage": [
-        "./dist/types/exports/storage.d.ts"
-      ],
-      "transaction": [
-        "./dist/types/exports/transaction.d.ts"
-      ],
-      "utils": [
-        "./dist/types/exports/utils.d.ts"
-      ],
-      "wallets": [
-        "./dist/types/exports/wallets.d.ts"
-      ],
-      "wallets/*": [
-        "./dist/types/exports/wallets/*.d.ts"
-      ],
-      "modules": [
-        "./dist/types/exports/modules.d.ts"
-      ],
-      "social": [
-        "./dist/types/exports/social.d.ts"
-      ]
+      "adapters/*": ["./dist/types/exports/adapters/*.d.ts"],
+      "auth": ["./dist/types/exports/auth.d.ts"],
+      "chains": ["./dist/types/exports/chains.d.ts"],
+      "contract": ["./dist/types/exports/contract.d.ts"],
+      "deploys": ["./dist/types/exports/deploys.d.ts"],
+      "event": ["./dist/types/exports/event.d.ts"],
+      "extensions/*": ["./dist/types/exports/extensions/*.d.ts"],
+      "pay": ["./dist/types/exports/pay.d.ts"],
+      "react": ["./dist/types/exports/react.d.ts"],
+      "react-native": ["./dist/types/exports/react-native.d.ts"],
+      "rpc": ["./dist/types/exports/rpc.d.ts"],
+      "storage": ["./dist/types/exports/storage.d.ts"],
+      "transaction": ["./dist/types/exports/transaction.d.ts"],
+      "utils": ["./dist/types/exports/utils.d.ts"],
+      "wallets": ["./dist/types/exports/wallets.d.ts"],
+      "wallets/*": ["./dist/types/exports/wallets/*.d.ts"],
+      "modules": ["./dist/types/exports/modules.d.ts"],
+      "social": ["./dist/types/exports/social.d.ts"]
     }
   },
   "browser": {
@@ -217,8 +181,9 @@
     "fuse.js": "7.0.0",
     "input-otp": "^1.4.1",
     "mipd": "0.0.7",
+    "ox": "0.1.3",
     "uqr": "0.1.2",
-    "viem": "2.21.42"
+    "viem": "2.21.44"
   },
   "peerDependencies": {
     "@aws-sdk/client-lambda": "^3",
@@ -355,6 +320,7 @@
     "msw": "^2.6.2",
     "prettier": "^3.3.2",
     "react": "19.0.0-rc-69d4b800-20241021",
+    "react-dom": "19.0.0-rc-69d4b800-20241021",
     "react-native": "0.76.1",
     "react-native-aes-gcm-crypto": "0.2.2",
     "react-native-passkey": "3.0.0",

packages/thirdweb/src/auth/verify-hash.ts

@@ -110,7 +110,7 @@ export async function verifyHash({
     });
 
     const hexResult = isHex(result) ? toBytes(result) : result;
-    return equalBytes(hexResult, toBytes("0x1"));
+    return equalBytes(hexResult, toBytes(true));
   } catch {
     // Some chains do not support the eth_call simulation and will fail, so we fall back to regular EIP1271 validation
     const validEip1271 = await verifyEip1271Signature({

packages/thirdweb/src/utils/encoding/from-bytes.ts

@@ -1,7 +1,5 @@
-import { assertSize } from "./helpers/assert-size.js";
-import type { Hex } from "./helpers/is-hex.js";
-import { trim } from "./helpers/trim.js";
-import { hexToBigInt, hexToNumber, uint8ArrayToHex } from "./hex.js";
+import * as ox__Bytes from "ox/Bytes";
+import { type Hex, uint8ArrayToHex } from "./hex.js";
 
 export type FromBytesParameters<
   TTo extends "string" | "hex" | "bigint" | "number" | "boolean",
@@ -86,17 +84,10 @@ export function bytesToBigInt(
   bytes: Uint8Array,
   opts: BytesToBigIntOpts = {},
 ): bigint {
-  if (typeof opts.size !== "undefined") {
-    assertSize(bytes, { size: opts.size });
-  }
-  const hex = uint8ArrayToHex(bytes, opts);
-  return hexToBigInt(hex, opts);
+  return ox__Bytes.toBigInt(bytes, opts);
 }
 
-export type BytesToBoolOpts = {
-  /** Size of the bytes. */
-  size?: number;
-};
+export type BytesToBoolOpts = ox__Bytes.toBoolean.Options;
 
 /**
  * Converts a byte array to a boolean value.
@@ -117,16 +108,7 @@ export function bytesToBool(
   bytes_: Uint8Array,
   opts: BytesToBoolOpts = {},
 ): boolean {
-  let bytes = bytes_;
-  if (typeof opts.size !== "undefined") {
-    assertSize(bytes, { size: opts.size });
-    bytes = trim(bytes);
-  }
-
-  if (bytes.length > 1 || (bytes[0] && bytes[0] > 1)) {
-    throw new Error(`Invalid boolean representation: ${bytes}`);
-  }
-  return Boolean(bytes[0]);
+  return ox__Bytes.toBoolean(bytes_, opts);
 }
 
 export type BytesToNumberOpts = BytesToBigIntOpts;
@@ -149,17 +131,10 @@ export function bytesToNumber(
   bytes: Uint8Array,
   opts: BytesToNumberOpts = {},
 ): number {
-  if (typeof opts.size !== "undefined") {
-    assertSize(bytes, { size: opts.size });
-  }
-  const hex = uint8ArrayToHex(bytes, opts);
-  return hexToNumber(hex, opts);
+  return ox__Bytes.toNumber(bytes, opts);
 }
 
-export type BytesToStringOpts = {
-  /** Size of the bytes. */
-  size?: number;
-};
+export type BytesToStringOpts = ox__Bytes.toString.Options;
 
 /**
  * Converts an array of bytes to a string using UTF-8 encoding.
@@ -179,10 +154,5 @@ export function bytesToString(
   bytes_: Uint8Array,
   opts: BytesToStringOpts = {},
 ): string {
-  let bytes = bytes_;
-  if (typeof opts.size !== "undefined") {
-    assertSize(bytes, { size: opts.size });
-    bytes = trim(bytes, { dir: "right" });
-  }
-  return new TextDecoder().decode(bytes);
+  return ox__Bytes.toString(bytes_, opts);
 }

packages/thirdweb/src/utils/encoding/helpers/assert-size.test.ts

@@ -1,4 +1,4 @@
-import { type Hex, isHex } from "./is-hex.js";
+import { type Hex, isHex } from "../hex.js";
 
 /**
  * Calculates the byte size of a Hex string or Uint8Array.