Skip to content

Commit 3fc2ea5

Browse files
gregfromstljoaquim-verges
authored andcommitted
revert misc change
1 parent 1fe8409 commit 3fc2ea5

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.changeset/tall-pots-live.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
---
44

55
# Breaking change
6+
67
We are making the following changes to the NFT component to provide better performance and fine-grain control over their internal fetching logic.
78
Moreover, you no longer have to wrap React.Suspense around said components!
89

910
### Old
11+
1012
```tsx
1113
<NFT>
1214
<React.Suspense fallback={"Loading stuff..."}>
@@ -18,19 +20,20 @@ Moreover, you no longer have to wrap React.Suspense around said components!
1820
```
1921

2022
### New
23+
2124
The new version comes with 2 new props: `loadingComponent` and `fallbackComponent`.
2225
Basically, `loadingComponent` takes in a component and show it _while the internal fetching is being done_
2326
`fallbackComponent` takes in a component and show it _once the data is failed to be resolved_
2427

2528
```tsx
2629
<NFTProvider contract={contract} tokenId={0n}>
2730
<NFTMedia
28-
loadingComponent={<span>Loading NFT Image</span>}
31+
loadingComponent={<span>Loading NFT Image</span>}
2932
fallbackComponent={<span>Failed to load NFT</span>}
3033
/>
31-
<NFT.Description
32-
loadingComponent={<span>Loading NFT Description</span>}
33-
fallbackComponent={<span>Failed to load NFT Description</span>}
34+
<NFTDescription
35+
loadingComponent={<span>Loading NFT Description</span>}
36+
fallbackComponent={<span>Failed to load NFT Description</span>}
3437
/>
3538
</NFT>
3639
```

apps/dashboard/src/app/(dashboard)/support/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ const HELP_PRODUCTS = [
100100
],
101101
},
102102
{
103-
title: "Miscellaneous",
103+
title: "Misc",
104104
icon: miscIcon,
105105
viewAllUrl: "https://support.thirdweb.com/",
106106
helpArticles: [

0 commit comments

Comments
 (0)