Apply CodeRabbit feedback improvements

Author: GiselleNessi

apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/apis/feedback.ts

@@ -1,5 +1,8 @@
 "use server";
 
+type FeedbackSubmitResult = { success: true } | { error: string };
+type FeedbackStatusResult = { hasFeedback: boolean } | { error: string };
+
 export async function submitSupportFeedback({
   rating,
   feedback,
@@ -8,7 +11,7 @@ export async function submitSupportFeedback({
   rating: number;
   feedback?: string;
   ticketId: string;
-}) {
+}): Promise<FeedbackSubmitResult> {
   try {
     // Fail fast on missing configuration
     const siwaUrl =
@@ -25,6 +28,10 @@ export async function submitSupportFeedback({
     }
 
     // Basic input validation/normalization
+    if (!ticketId?.trim()) {
+      return { error: "ticketId is required." };
+    }
+
     if (!Number.isInteger(rating) || rating < 1 || rating > 5) {
       return { error: "Rating must be an integer between 1 and 5." };
     }
@@ -37,7 +44,7 @@ export async function submitSupportFeedback({
     const payload = {
       rating: rating.toString(),
       feedback: normalizedFeedback,
-      ticket_id: ticketId || null,
+      ticket_id: ticketId,
     };
 
     const ac = new AbortController();
@@ -65,8 +72,15 @@ export async function submitSupportFeedback({
   }
 }
 
-export async function checkFeedbackStatus(ticketId: string) {
+export async function checkFeedbackStatus(
+  ticketId: string,
+): Promise<FeedbackStatusResult> {
   try {
+    // Basic input validation
+    if (!ticketId?.trim()) {
+      return { error: "ticketId is required." };
+    }
+
     // Fail fast on missing configuration
     const siwaUrl =
       process.env.SIWA_URL ?? process.env.NEXT_PUBLIC_SIWA_URL ?? "";