update

kien-ngo · kien-ngo · commit 49718c05b8c8 · 2024-11-07T22:47:27.000+07:00
diff --git a/apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/platform-fees.tsx b/apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/platform-fees.tsx
@@ -86,7 +86,7 @@ export const SettingsPlatformFees = ({
           });
           // In the v4 hook we defaulted recipient to address_zero and bps to `0`
           // but let's actually throw an error here for better transparency
-          if (!data.platform_fee_basis_points) {
+          if (data.platform_fee_basis_points === undefined) {
             return toast.error("Please enter valid basis points.");
           }
           if (!data.platform_fee_recipient) {
diff --git a/apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/royalties.tsx b/apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/settings/components/royalties.tsx
@@ -99,7 +99,7 @@ export const SettingsRoyalties = ({
           });
           // In the v4 hook we defaulted recipient to address_zero and bps to `0`
           // but let's actually throw an error here for better transparency
-          if (!d.seller_fee_basis_points) {
+          if (d.seller_fee_basis_points === undefined) {
             return toast.error("Please enter valid basis points.");
           }
           if (!d.fee_recipient) {

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ export const SettingsPlatformFees = ({`
`86`	`86`	`});`
`87`	`87`	// In the v4 hook we defaulted recipient to address_zero and bps to `0`
`88`	`88`	`// but let's actually throw an error here for better transparency`
`89`		`- if (!data.platform_fee_basis_points) {`
	`89`	`+ if (data.platform_fee_basis_points === undefined) {`
`90`	`90`	`return toast.error("Please enter valid basis points.");`
`91`	`91`	`}`
`92`	`92`	`if (!data.platform_fee_recipient) {`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ export const SettingsRoyalties = ({`
`99`	`99`	`});`
`100`	`100`	// In the v4 hook we defaulted recipient to address_zero and bps to `0`
`101`	`101`	`// but let's actually throw an error here for better transparency`
`102`		`- if (!d.seller_fee_basis_points) {`
	`102`	`+ if (d.seller_fee_basis_points === undefined) {`
`103`	`103`	`return toast.error("Please enter valid basis points.");`
`104`	`104`	`}`
`105`	`105`	`if (!d.fee_recipient) {`