[SDK] fix: Improve WalletConnect mobile connection handling (#6042)

Author: joaquim-verges

.changeset/nervous-frogs-pay.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix prompting for generic WC connection on mobile

apps/playground-web/src/components/sign-in/hooks.tsx

@@ -1,5 +1,4 @@
 "use client";
-
 import {
   useActiveAccount,
   useActiveWallet,
@@ -39,7 +38,9 @@ export function HooksPreview() {
         </>
       ) : (
         <Button variant="default" onClick={connect}>
-          Connect with Metamask
+          {connectMutation.isConnecting
+            ? "Connecting..."
+            : "Connect with Metamask"}
         </Button>
       )}
     </div>

packages/thirdweb/src/wallets/wallet-connect/controller.ts

@@ -93,12 +93,14 @@ export async function connectWC(
   let { onDisplayUri } = wcOptions || {};
 
   // use default sessionHandler unless onDisplayUri is explicitly provided
-  if (!onDisplayUri && sessionHandler && walletId !== "walletConnect") {
+  if (!onDisplayUri && sessionHandler) {
     const walletInfo = await getWalletInfo(walletId);
     const deeplinkHandler = (uri: string) => {
       const appUrl = walletInfo.mobile.native || walletInfo.mobile.universal;
       if (!appUrl) {
-        throw new Error("No app url found for wallet connect to redirect to.");
+        // generic wc uri
+        sessionHandler(uri);
+        return;
       }
       const fullUrl = formatWalletConnectUrl(appUrl, uri).redirect;
       sessionHandler(fullUrl);