Updated Mintable Modules

- mintWithRole now passes in empty string if the nft passed in is the empty string

Author: GWSzeto

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Mintable.tsx

@@ -99,8 +99,8 @@ function MintableModule(props: ModuleInstanceProps) {
       if (!hasMinterRole.data) {
         const grantRoleTx = prepareContractCall({
           contract,
-          method: "function grantRole(address user, uint256 role) public",
-          params: [ownerAccount.address || "", MINTER_ROLE],
+          method: "function grantRoles(address user, uint256 roles)",
+          params: [ownerAccount.address, MINTER_ROLE],
         });
 
         await sendAndConfirmTransaction({

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/module-instance.tsx

@@ -31,7 +31,7 @@ export function ModuleInstance(props: ModuleInstanceProps) {
     return <TransferableModule {...props} />;
   }
 
-  if (props.contractInfo.name.includes("Mintable-ignore")) {
+  if (props.contractInfo.name.includes("Mintable")) {
     return <MintableModule {...props} />;
   }
 

packages/thirdweb/src/extensions/modules/MintableERC1155/mintWithRole.ts

@@ -45,13 +45,17 @@ export function mintWithRole(
   return generatedMint({
     contract: options.contract,
     asyncParams: async () => {
-      const batchOfUris = await uploadOrExtractURIs(
-        [options.nft],
-        options.contract.client,
-      );
-      const baseURI = getBaseUriFromBatch(batchOfUris);
+      let baseURI = "";
+      if (options.nft) {
+        const batchOfUris = await uploadOrExtractURIs(
+          [options.nft],
+          options.contract.client,
+        );
+        baseURI = getBaseUriFromBatch(batchOfUris);
+      }
 
       const tokenId = options.tokenId ?? maxUint256;
+      console.log("tokenId: ", tokenId);
       return {
         to: getAddress(options.to),
         tokenId,

packages/thirdweb/src/extensions/modules/MintableERC721/mintWithRole.ts

@@ -41,11 +41,14 @@ export function mintWithRole(options: BaseTransactionOptions<NFTMintParams>) {
   return generatedMint({
     contract: options.contract,
     asyncParams: async () => {
-      const batchOfUris = await uploadOrExtractURIs(
-        options.nfts,
-        options.contract.client,
-      );
-      const baseURI = getBaseUriFromBatch(batchOfUris);
+      let baseURI = "";
+      if (options.nfts?.[0] !== "") {
+        const batchOfUris = await uploadOrExtractURIs(
+          options.nfts,
+          options.contract.client,
+        );
+        baseURI = getBaseUriFromBatch(batchOfUris);
+      }
 
       return {
         to: getAddress(options.to),