[SDK] Fix Coinbase wallet transaction desktop popup for mobile QR login (#8253)

Author: joaquim-verges

.changeset/sixty-bobcats-add.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Fix cb wallet transaction desktop popup when logged in via mobile QR code

packages/thirdweb/src/wallets/coinbase/coinbase-web.ts

@@ -188,7 +188,17 @@ function createAccount({
     onTransactionRequested: async () => {
       // make sure to show the coinbase popup BEFORE doing any transaction preprocessing
       // otherwise the popup might get blocked in safari
-      await showCoinbasePopup(provider);
+      // but only if using cb smart wallet (web based)
+      if (window.localStorage) {
+        // this is the local storage key for the signer type in the cb web sdk
+        // value can be "scw" (web) or "walletlink" (mobile wallet)
+        const signerType = window.localStorage.getItem(
+          "-CBWSDK:SignerConfigurator:SignerType",
+        );
+        if (signerType === "scw") {
+          await showCoinbasePopup(provider);
+        }
+      }
     },
     async sendTransaction(tx: SendTransactionOption) {
       const transactionHash = (await provider.request({

packages/thirdweb/src/x402/fetchWithPayment.ts

@@ -82,6 +82,7 @@ export function wrapFetchWithPayment(
       parsedPaymentRequirements,
       chain.id,
       "exact",
+      error,
     );
 
     if (!selectedPaymentRequirements) {
@@ -141,10 +142,11 @@ function defaultPaymentRequirementsSelector(
   paymentRequirements: RequestedPaymentRequirements[],
   chainId: number,
   scheme: "exact",
+  error?: string,
 ) {
   if (!paymentRequirements.length) {
     throw new Error(
-      "No valid payment requirements found in server 402 response",
+      `No valid payment requirements found in server 402 response. ${error}`,
     );
   }
   const currentWalletNetwork = ChainIdToNetwork[chainId] || `eip155:${chainId}`;