feat(sdk): migrate signMessage to ox

Author: gregfromstl

packages/thirdweb/src/utils/signatures/sign-message.ts

@@ -1,9 +1,10 @@
+import * as ox__Hex from "ox/Hex";
+import * as ox__PersonalMessage from "ox/PersonalMessage";
+import * as ox__Secp256k1 from "ox/Secp256k1";
+import * as ox__Signature from "ox/Signature";
 import type { Account } from "../../wallets/interfaces/wallet.js";
 import type { Hex } from "../encoding/hex.js";
-import { hashMessage } from "../hashing/hashMessage.js";
 import type { Prettify } from "../type-utils.js";
-import { sign } from "./sign.js";
-import { signatureToHex } from "./signature-to-hex.js";
 
 type Message = Prettify<
   | string
@@ -59,9 +60,14 @@ export function signMessage(
   options: SignMessageOptions | { message: Message; account: Account },
 ): Hex | Promise<Hex> {
   if ("privateKey" in options) {
-    const { message, privateKey } = options;
-    const signature = sign({ hash: hashMessage(message), privateKey });
-    return signatureToHex(signature);
+    const payload = ox__PersonalMessage.getSignPayload(
+      typeof options.message === "object"
+        ? options.message.raw
+        : ox__Hex.fromString(options.message),
+    );
+    return ox__Signature.toHex(
+      ox__Secp256k1.sign({ payload, privateKey: options.privateKey }),
+    );
   }
   if ("account" in options) {
     const { message, account } = options;

packages/thirdweb/src/utils/signatures/signature-to-hex.ts

@@ -1,7 +1,8 @@
 import { secp256k1 } from "@noble/curves/secp256k1";
-import type { Signature } from "viem";
 import { type Hex, hexToBigInt } from "../encoding/hex.js";
 
+// We can't migrate this to Ox without breaking changes
+
 /**
  * Converts a signature to a hex string.
  * @param signature The signature to convert.
@@ -25,7 +26,12 @@ import { type Hex, hexToBigInt } from "../encoding/hex.js";
  * ```
  * @utils
  */
-export function signatureToHex(signature: Signature): Hex {
+export function signatureToHex(signature: {
+  r: Hex;
+  s: Hex;
+  v?: bigint;
+  yParity?: number;
+}): Hex {
   const { r, s, v, yParity } = signature;
   const yParity_ = (() => {
     if (yParity === 0 || yParity === 1) return yParity;