Dashboard: Fix Payment link buy completion tracking

Author: MananTank

apps/dashboard/src/@/analytics/report.ts

@@ -435,11 +435,8 @@ export function reportPaymentLinkCreated(properties: {
  * ### Who is responsible for this event?
  * @greg
  */
-export function reportPaymentLinkBuySuccessful(properties: {
-  linkId: string;
-  clientId: string;
-}) {
-  posthog.capture("payment link buy successful", properties);
+export function reportPaymentLinkBuySuccessful() {
+  posthog.capture("payment link buy successful");
 }
 
 /**
@@ -451,8 +448,6 @@ export function reportPaymentLinkBuySuccessful(properties: {
  * @greg
  */
 export function reportPaymentLinkBuyFailed(properties: {
-  linkId: string;
-  clientId: string;
   errorMessage: string;
 }) {
   posthog.capture("payment link buy failed", properties);

apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx

@@ -62,24 +62,16 @@ export function PayPageWidget({
         image={image}
         name={name}
         onSuccess={() => {
+          reportPaymentLinkBuySuccessful();
+
           if (!redirectUri) return;
           const url = new URL(redirectUri);
-          if (paymentLinkId && clientId) {
-            reportPaymentLinkBuySuccessful({
-              linkId: paymentLinkId,
-              clientId: clientId,
-            });
-          }
           return window.open(url.toString());
         }}
         onError={(error) => {
-          if (paymentLinkId && clientId) {
-            reportPaymentLinkBuyFailed({
-              linkId: paymentLinkId,
-              clientId: clientId,
-              errorMessage: error.message,
-            });
-          }
+          reportPaymentLinkBuyFailed({
+            errorMessage: error.message,
+          });
         }}
         paymentLinkId={paymentLinkId}
         purchaseData={purchaseData}