test fixes

Author: gregfromstl

packages/thirdweb/src/utils/signatures/sign-typed-data.ts

@@ -1,13 +1,12 @@
-import type { Hex } from "../encoding/hex.js";
-import * as ox__TypedData from "ox/TypedData";
 import * as ox__Secp256k1 from "ox/Secp256k1";
-import * as ox__Hex from "ox/Hex";
 import * as ox__Signature from "ox/Signature";
+import * as ox__TypedData from "ox/TypedData";
+import type { Hex } from "../encoding/hex.js";
 
 export type SignTypedDataOptions<
   typedData extends
-  | ox__TypedData.TypedData
-  | Record<string, unknown> = ox__TypedData.TypedData,
+    | ox__TypedData.TypedData
+    | Record<string, unknown> = ox__TypedData.TypedData,
   primaryType extends keyof typedData | "EIP712Domain" = keyof typedData,
 > = ox__TypedData.Definition<typedData, primaryType> & {
   privateKey: Hex;
@@ -39,7 +38,7 @@ export function signTypedData<
 
   const signature = ox__Secp256k1.sign({
     payload,
-    privateKey: ox__Hex.fromString(privateKey),
+    privateKey,
   });
 
   return ox__Signature.toHex(signature);

packages/thirdweb/src/wallets/wallet-connect/receiver/session-request.test.ts

@@ -141,7 +141,7 @@ describe("session_request", () => {
       personalSignRequest = cloneObject(REQUEST_EVENT_MOCK);
       personalSignRequest.params.request.method = "personal_sign";
       personalSignRequest.params.request.params = [
-        "my message",
+        "0xeeeee",
         TEST_ACCOUNT_A.address,
       ] as WalletConnectSignRequestPrams;
     });
@@ -159,7 +159,7 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x66ea9c2ac4a99a5ac26f5fa3e800171036210e135d486f1d0d02d64eaa7dd56275b4323e153e62c1fad57a6be54420248ed54604f4857ec75ce7761eefad10e41c",
+            "0x7b7806017c0666b88ff1a51a2af716b808c4974bdb31a4fb734fe2d16c121766363847d2556eb466d1cd04b26541aa5a2a1f5be4154cfd9bef8137dfb7b711ff01",
         },
       });
     });
@@ -221,7 +221,7 @@ describe("session_request", () => {
       ethSignRequest = cloneObject(REQUEST_EVENT_MOCK);
       ethSignRequest.params.request.method = "eth_sign";
       ethSignRequest.params.request.params = [
-        "my message",
+        "0xeeeee",
         TEST_ACCOUNT_A.address,
       ] as WalletConnectSignRequestPrams;
     });
@@ -239,14 +239,14 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x66ea9c2ac4a99a5ac26f5fa3e800171036210e135d486f1d0d02d64eaa7dd56275b4323e153e62c1fad57a6be54420248ed54604f4857ec75ce7761eefad10e41c",
+            "0x7b7806017c0666b88ff1a51a2af716b808c4974bdb31a4fb734fe2d16c121766363847d2556eb466d1cd04b26541aa5a2a1f5be4154cfd9bef8137dfb7b711ff01",
         },
       });
     });
 
     it("should reject if active account address differs from requested address", async () => {
       ethSignRequest.params.request.params = [
-        "my message",
+        "0xeeeee",
         TEST_ACCOUNT_B.address,
       ] as WalletConnectSignRequestPrams;
 
@@ -323,7 +323,7 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e5921b",
+            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e59200",
         },
       });
     });
@@ -347,7 +347,7 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e5921b",
+            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e59200",
         },
       });
     });
@@ -378,7 +378,7 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e5921b",
+            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e59200",
         },
       });
     });
@@ -402,7 +402,7 @@ describe("session_request", () => {
           id: REQUEST_EVENT_MOCK.id,
           jsonrpc: "2.0",
           result:
-            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e5921b",
+            "0x32f3d5975ba38d6c2fba9b95d5cbed1febaa68003d3d588d51f2de522ad54117760cfc249470a75232552e43991f53953a3d74edf6944553c6bef2469bb9e59200",
         },
       });
     });