Skip to content

Commit 9acb116

Browse files
committed
address reviews & remove SiweExternal
1 parent 0f98e01 commit 9acb116

File tree

7 files changed

+6
-68
lines changed

7 files changed

+6
-68
lines changed

apps/portal/src/app/dotnet/godot/page.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ To add the Thirdweb .NET SDK to your Godot project, you will need to manually ed
2424
```xml
2525
<ItemGroup>
2626
<!-- Other NuGet package references -->
27-
<PackageReference Include="Thirdweb" Version="2.4.0" />
27+
<PackageReference Include="Thirdweb" Version="3.0.0" />
2828
<!-- Update with the latest version when necessary -->
2929
</ItemGroup>
3030
```

apps/portal/src/app/dotnet/wallets/user-wallet/page.mdx

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ var wallet = await InAppWallet.Create(client: client, authProvider: AuthProvider
3636
var wallet = await InAppWallet.Create(client: client, authProvider: AuthProvider.Backend, walletSecret: "very-secret");
3737
// SIWE
3838
var wallet = await InAppWallet.Create(client: client, authProvider: AuthProvider.Siwe, siweSigner: anyExternalWallet);
39-
// SIWE External
40-
var wallet = await InAppWallet.Create(client: client, authProvider: AuthProvider.SiweExternal);
4139
```
4240

4341
### EcosystemWallet
@@ -61,8 +59,6 @@ var wallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosyste
6159
var wallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosystem.my-ecosystem", authProvider: AuthProvider.Backend, walletSecret: "very-secret");
6260
// SIWE
6361
var wallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosystem.my-ecosystem", authProvider: AuthProvider.Siwe, siweSigner: anyExternalWallet);
64-
// SIWE External
65-
var wallet = await EcosystemWallet.Create(client: client, ecosystemId: "ecosystem.my-ecosystem", authProvider: AuthProvider.SiweExternal);
6662
```
6763

6864
Once a wallet is created, you can always resume the session:
@@ -135,17 +131,6 @@ var backendAddress = await wallet.LoginWithBackend();
135131
```csharp
136132
// SIWE
137133
var address = await wallet.LoginWithSiwe(chainId: 1);
138-
139-
// SIWE External
140-
var address = await wallet.LoginWithSiweExternal(
141-
isMobile: false,
142-
browserOpenAction: (url) =>
143-
{
144-
var psi = new ProcessStartInfo { FileName = url, UseShellExecute = true };
145-
_ = Process.Start(psi);
146-
},
147-
forceWalletIds: new List<string> { "io.metamask", "com.coinbase.wallet", "xyz.abs" }
148-
);
149134
```
150135

151136
Limiting `forceWalletIds` to a single value skips the wallet picker and deep-links into that specific wallet provider.

apps/portal/src/app/unity/v6/contracts/page.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { GraduationCap } from "lucide-react";
44
export const metadata = createMetadata({
55
title: "ThirdwebContract | Thirdweb Unity SDK",
66
description:
7-
"Instantiate a PrivateKeyWallet to sign transactions and messages.",
7+
"Interact with any EVM smart contract through the ThirdwebContract wrapper in the Unity SDK.",
88
});
99

1010
# ThirdwebContract

apps/portal/src/app/unity/v6/getting-started/page.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ import {
99
import { GraduationCap } from "lucide-react";
1010

1111
export const metadata = createMetadata({
12-
title: "Interacting with Contracts | thirdweb Unity SDK",
12+
title: "Getting Started | thirdweb Unity SDK",
1313
description:
14-
"Learn how to interact with smart contracts using the thirdweb Unity SDK.",
14+
"Kick off your Unity integration with the thirdweb Unity SDK and learn the essential setup steps.",
1515
});
1616

1717
# Getting Started

apps/portal/src/app/unity/v6/wallets/account-abstraction/page.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ We recommend using Smart Wallets as the primary wallet type for your users.
4242
### Connecting to a Smart Wallet directly
4343

4444
```csharp
45-
var smartWalletOptions = new SmartWalletOptions(sponsorGas: true)
45+
var smartWalletOptions = new SmartWalletOptions(sponsorGas: true);
4646
var options = new WalletOptions(..., smartWalletOptions: smartWalletOptions);
4747
var wallet = await ThirdwebManager.Instance.ConnectWallet(options);
4848
```
4949

5050
### Upgrading an existing wallet to a Smart Wallet
5151

5252
```csharp
53-
var smartWalletOptions = new SmartWalletOptions(sponsorGas: true)
53+
var smartWalletOptions = new SmartWalletOptions(sponsorGas: true);
5454
var smartWallet = await ThirdwebManager.Instance.UpgradeToSmartWallet(
5555
personalWallet: myExistingIThirdwebWallet,
5656
chainId: 1,

apps/portal/src/app/unity/v6/wallets/ecosystem-wallet/page.mdx

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Ecosystem Wallets support a variety of login methods:
2626
- Guest (Onboard easily, link other accounts later)
2727
- Backend (Server Wallets)
2828
- Siwe (Login with a separate wallet supported by the SDK)
29-
- SiweExternal (Login with an external wallet that only supports web using a browser loading a static thirdweb React page temporarily)
3029

3130
### Login with Email
3231

@@ -97,29 +96,6 @@ var wallet = await ThirdwebManager.Instance.ConnectWallet(options);
9796

9897
Will use the external wallet to sign a message and login to the EcosystemWallet.
9998

100-
### Login with SiweExternal
101-
102-
```csharp
103-
var ecosystemWalletOptions = new EcosystemWalletOptions(ecosystemId: "ecosystem.your-ecosystem", authprovider: AuthProvider.SiweExternal)
104-
var options = new WalletOptions(
105-
provider: WalletProvider.EcosystemWallet,
106-
chainId: 421614,
107-
ecosystemWalletOptions: ecosystemWalletOptions
108-
);
109-
var wallet = await ConnectWallet(options);
110-
```
111-
112-
Will open a browser and load a static thirdweb React page to authenticate the user and redirect back to the game.
113-
You can pass `forceSiweExternalWalletIds` to force the page to use one or more wallets.
114-
115-
Example:
116-
```csharp
117-
var ecosystemWalletOptions = new EcosystemWalletOptions(
118-
ecosystemId: "ecosystem.your-ecosystem",
119-
authprovider: AuthProvider.SiweExternal,
120-
forceSiweExternalWalletIds: new List<string> { "xyz.abs" });
121-
```
122-
12399
### Login with Custom Auth - OIDC Compatible
124100

125101
```csharp

apps/portal/src/app/unity/v6/wallets/in-app-wallet/page.mdx

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ In-App Wallets support a variety of login methods:
2424
- Guest (Onboard easily, link other accounts later)
2525
- Backend (Server Wallets)
2626
- Siwe (Login with a separate wallet supported by the SDK)
27-
- SiweExternal (Login with an external wallet that only supports web using a browser loading a static thirdweb React page temporarily)
2827

2928
### Login with Email
3029

@@ -82,28 +81,6 @@ var wallet = await ThirdwebManager.Instance.ConnectWallet(options);
8281

8382
Will use a separate wallet to sign a message and login to the InAppWallet.
8483

85-
### Login with SiweExternal
86-
87-
```csharp
88-
var inAppWalletOptions = new InAppWalletOptions(authprovider: AuthProvider.SiweExternal)
89-
var options = new WalletOptions(
90-
provider: WalletProvider.InAppWallet,
91-
chainId: 421614,
92-
inAppWalletOptions: inAppWalletOptions
93-
);
94-
var wallet = await ConnectWallet(inAppWalletOptions);
95-
```
96-
97-
Will open a browser and load a static thirdweb React page to authenticate the user and redirect back to the game.
98-
You can pass `forceSiweExternalWalletIds` to force the page to use one or more wallets.
99-
100-
Example:
101-
```csharp
102-
var inAppWalletOptions = new InAppWalletOptions(
103-
authprovider: AuthProvider.SiweExternal,
104-
forceSiweExternalWalletIds: new List<string> { "xyz.abs" });
105-
```
106-
10784
### Login with Custom Auth - OIDC Compatible
10885

10986
```csharp

0 commit comments

Comments
 (0)