ui fixes, re-enable tests, stringify error

Author: joaquim-verges

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/tx/[id]/transaction-details-ui.tsx

@@ -3,7 +3,7 @@
 import { format, formatDistanceToNowStrict } from "date-fns";
 import { ExternalLinkIcon, InfoIcon } from "lucide-react";
 import Link from "next/link";
-import { type ThirdwebClient, toEther } from "thirdweb";
+import { hexToNumber, isHex, type ThirdwebClient, toEther } from "thirdweb";
 import type { Project } from "@/api/projects";
 import { WalletAddress } from "@/components/blocks/wallet-address";
 import { Badge } from "@/components/ui/badge";
@@ -68,7 +68,7 @@ export function TransactionDetailsUI({
   // Gas information
   const gasUsed =
     executionResult && "actualGasUsed" in executionResult
-      ? `${executionResult.actualGasUsed}`
+      ? `${isHex(executionResult.actualGasUsed) ? hexToNumber(executionResult.actualGasUsed) : executionResult.actualGasUsed}`
       : "N/A";
 
   const gasCost =
@@ -339,7 +339,9 @@ export function TransactionDetailsUI({
                   Block Number
                 </div>
                 <div className="text-sm md:w-2/3">
-                  {transaction.confirmedAtBlockNumber}
+                  {isHex(transaction.confirmedAtBlockNumber)
+                    ? hexToNumber(transaction.confirmedAtBlockNumber)
+                    : transaction.confirmedAtBlockNumber}
                 </div>
               </div>
             )}

packages/thirdweb/src/engine/server-wallet.test.ts

@@ -9,6 +9,7 @@ import { sepolia } from "../chains/chain-definitions/sepolia.js";
 import { getContract } from "../contract/contract.js";
 import { setContractURI } from "../extensions/common/__generated__/IContractMetadata/write/setContractURI.js";
 import { mintTo } from "../extensions/erc20/write/mintTo.js";
+import { setApprovalForAll } from "../extensions/erc1155/__generated__/IERC1155/write/setApprovalForAll.js";
 import { claimTo } from "../extensions/erc1155/drops/write/claimTo.js";
 import { getAllActiveSigners } from "../extensions/erc4337/__generated__/IAccountPermissions/read/getAllActiveSigners.js";
 import { sendTransaction } from "../transaction/actions/send-transaction.js";
@@ -44,13 +45,13 @@ describe.runIf(
       });
       serverWallet = Engine.serverWallet({
         address: process.env.ENGINE_CLOUD_WALLET_ADDRESS as string,
-        chain: arbitrumSepolia,
+        chain: sepolia,
         client: TEST_CLIENT,
         vaultAccessToken: process.env.VAULT_TOKEN as string,
       });
     });
 
-    it.skip("should create a server wallet", async () => {
+    it("should create a server wallet", async () => {
       const serverWallet = await Engine.createServerWallet({
         client: TEST_CLIENT,
         label: "My Server Wallet",
@@ -155,14 +156,14 @@ describe.runIf(
 
     it("should send a extension tx", async () => {
       const tokenContract = getContract({
-        address: "0x87C52295891f208459F334975a3beE198fE75244",
+        address: "0x638263e3eAa3917a53630e61B1fBa685308024fa",
         chain: baseSepolia,
         client: TEST_CLIENT,
       });
-      const claimTx = mintTo({
-        amount: "0.001",
+      const claimTx = setApprovalForAll({
+        approved: true,
         contract: tokenContract,
-        to: serverWallet.address,
+        operator: "0x4b8ceC1Eb227950F0bfd034449B2781e689242A1",
       });
       const tx = await sendTransaction({
         account: serverWallet,
@@ -173,19 +174,21 @@ describe.runIf(
 
     it("should enqueue a batch of txs", async () => {
       const tokenContract = getContract({
-        address: "0x87C52295891f208459F334975a3beE198fE75244",
+        address: "0x638263e3eAa3917a53630e61B1fBa685308024fa",
         chain: baseSepolia,
         client: TEST_CLIENT,
       });
-      const claimTx1 = mintTo({
-        amount: "0.001",
+      const claimTx1 = claimTo({
         contract: tokenContract,
+        quantity: 1n,
         to: serverWallet.address,
+        tokenId: 2n,
       });
-      const claimTx2 = mintTo({
-        amount: "0.002",
+      const claimTx2 = claimTo({
         contract: tokenContract,
+        quantity: 1n,
         to: serverWallet.address,
+        tokenId: 2n,
       });
       const tx = await serverWallet.enqueueBatchTransaction({
         transactions: [claimTx1, claimTx2],

packages/thirdweb/src/engine/wait-for-tx-hash.ts

@@ -38,7 +38,7 @@ export async function waitForTransactionHash(args: {
     switch (status) {
       case "FAILED": {
         throw new Error(
-          `Transaction failed: ${executionResult.error || "Unknown error"}`,
+          `Transaction failed: ${stringify(executionResult.error) || "Unknown error"}`,
         );
       }
       case "CONFIRMED": {