fix asset units

Author: kumaryash90

packages/thirdweb/src/assets/create-token-by-impl-config.ts

@@ -1,6 +1,6 @@
-import { getContract } from "src/contract/contract.js";
 import type { Hex } from "viem";
 import { NATIVE_TOKEN_ADDRESS, ZERO_ADDRESS } from "../constants/addresses.js";
+import { getContract } from "../contract/contract.js";
 import { parseEventLogs } from "../event/actions/parse-logs.js";
 import { assetCreatedEvent } from "../extensions/assets/__generated__/AssetEntrypointERC20/events/AssetCreated.js";
 import { createAssetByImplementationConfig } from "../extensions/assets/__generated__/AssetEntrypointERC20/write/createAssetByImplementationConfig.js";
@@ -10,6 +10,7 @@ import { getRpcClient } from "../rpc/rpc.js";
 import { sendAndConfirmTransaction } from "../transaction/actions/send-and-confirm-transaction.js";
 import { keccakId } from "../utils/any-evm/keccak-id.js";
 import { toHex } from "../utils/encoding/hex.js";
+import { toUnits } from "../utils/units.js";
 import {
   CreateHook,
   DEFAULT_MAX_SUPPLY_ERC20,
@@ -96,7 +97,10 @@ export async function createTokenByImplConfig(options: CreateTokenOptions) {
       createHookData: hookData,
     },
     params: {
-      amount: params.maxSupply || DEFAULT_MAX_SUPPLY_ERC20,
+      amount: toUnits(
+        params.maxSupply.toString() || DEFAULT_MAX_SUPPLY_ERC20.toString(),
+        18,
+      ),
       referrer: ZERO_ADDRESS,
       salt,
       data: encodedInitData,

packages/thirdweb/src/assets/create-token.test.ts

@@ -4,6 +4,7 @@ import { TEST_CLIENT } from "../../test/src/test-clients.js";
 import { TEST_ACCOUNT_A } from "../../test/src/test-wallets.js";
 import { getContract } from "../contract/contract.js";
 import { name } from "../extensions/common/read/name.js";
+import { totalSupply } from "../extensions/erc20/__generated__/IERC20/read/totalSupply.js";
 import { createTokenByImplConfig } from "./create-token-by-impl-config.js";
 
 describe.runIf(process.env.TW_SECRET_KEY)("create token by impl config", () => {
@@ -29,5 +30,15 @@ describe.runIf(process.env.TW_SECRET_KEY)("create token by impl config", () => {
       }),
     });
     expect(tokenName).to.eq("Test");
+
+    const supply = await totalSupply({
+      contract: getContract({
+        client: TEST_CLIENT,
+        chain: ANVIL_CHAIN,
+        address: token,
+      }),
+    });
+
+    console.log("supply: ", supply);
   });
 });

packages/thirdweb/src/assets/create-token.ts

@@ -1,3 +1,4 @@
+import { toUnits } from "src/utils/units.js";
 import type { Hex } from "viem";
 import { NATIVE_TOKEN_ADDRESS, ZERO_ADDRESS } from "../constants/addresses.js";
 import { getContract } from "../contract/contract.js";
@@ -76,7 +77,10 @@ export async function createToken(options: CreateTokenOptions) {
     contract: entrypoint,
     creator,
     createParams: {
-      amount: params.maxSupply || DEFAULT_MAX_SUPPLY_ERC20,
+      amount: toUnits(
+        params.maxSupply.toString() || DEFAULT_MAX_SUPPLY_ERC20.toString(),
+        18,
+      ),
       referrer: ZERO_ADDRESS,
       salt,
       data: encodedInitData,

packages/thirdweb/src/assets/token-utils.ts

@@ -4,6 +4,7 @@ import { NATIVE_TOKEN_ADDRESS, ZERO_ADDRESS } from "../constants/addresses.js";
 import { encodeInitialize } from "../extensions/assets/__generated__/ERC20Asset/write/initialize.js";
 import { upload } from "../storage/upload.js";
 import { encodeAbiParameters } from "../utils/abi/encodeAbiParameters.js";
+import { toUnits } from "../utils/units.js";
 import {
   DEFAULT_MAX_SUPPLY_ERC20,
   DEFAULT_POOL_FEE,
@@ -39,7 +40,10 @@ export async function encodeInitParams(options: {
     name: params.name,
     symbol: params.symbol || params.name,
     contractURI,
-    maxSupply: params.maxSupply || DEFAULT_MAX_SUPPLY_ERC20,
+    maxSupply: toUnits(
+      params.maxSupply.toString() || DEFAULT_MAX_SUPPLY_ERC20.toString(),
+      18,
+    ),
     owner: creator,
   });
 }