fix: auto connect should return true when connected to wallet

refactor: move connection manager into an internal construct

Author: ElasticBottle

packages/thirdweb/src/wallets/connection/autoConnect.ts

@@ -3,40 +3,39 @@ import { createWallet } from "../create-wallet.js";
 import { getDefaultWallets } from "../defaultWallets.js";
 import { getInstalledWalletProviders } from "../injected/mipdStore.js";
 import type { Wallet } from "../interfaces/wallet.js";
-import type { ConnectionManager } from "../manager/index.js";
+import { createConnectionManager } from "../manager/index.js";
 import { autoConnectCore } from "./autoConnectCore.js";
 import type { AutoConnectProps } from "./types.js";
 
 /**
- * Attempts to automatically connect to a wallet based on the provided configuration.
+ * Attempts to automatically connect to the last connected wallet.
  * It combines both specified wallets and installed wallet providers that aren't already specified.
  *
  * @example
  *
  * ```tsx
  * import { autoConnect } from "thirdweb/wallets";
  *
- * const walletManager = createConnectionManager();
  * const autoConnected = await autoConnect({
  *  client,
- *  walletManager,
+ *  onConnect: (wallet) => {
+ *    console.log("wallet", wallet);
+ *  },
  * });
  * ```
  *
- *
  * @param props - The auto-connect configuration properties
  * @param props.wallets - Array of wallet instances to consider for auto-connection
- * @param walletManager - The connection manager instance handling wallet connections
  * @returns {boolean} a promise resolving to true or false depending on whether the auto connect function connected to a wallet or not
  */
 export const autoConnect = async (
   props: AutoConnectProps & {
-    wallets: Wallet[];
-    walletManager: ConnectionManager;
+    wallets?: Wallet[];
   },
 ) => {
   const wallets = props.wallets || getDefaultWallets(props);
-  return autoConnectCore({
+  const manager = createConnectionManager(webLocalStorage);
+  const result = await autoConnectCore({
     storage: webLocalStorage,
     props: {
       ...props,
@@ -53,6 +52,7 @@ export const autoConnect = async (
 
       return installedWallets;
     },
-    manager: props.walletManager,
+    manager,
   });
+  return result;
 };

packages/thirdweb/src/wallets/connection/autoConnectCore.ts

@@ -92,7 +92,6 @@ export const autoConnectCore = async ({
   // in that case, we default to the passed chain to connect to
   const lastConnectedChain =
     (await getLastConnectedChain(storage)) || props.chain;
-
   const availableWallets = [...wallets, ...(getInstalledWallets?.() ?? [])];
   const activeWallet =
     lastActiveWalletId &&
@@ -127,15 +126,12 @@ export const autoConnectCore = async ({
             client: props.client,
             accountAbstraction: props.accountAbstraction,
           }));
-
       if (connectedWallet) {
-        if (onConnect) {
-          try {
-            onConnect(connectedWallet);
-            autoConnected = true;
-          } catch {
-            // ignore
-          }
+        autoConnected = true;
+        try {
+          onConnect?.(connectedWallet);
+        } catch {
+          // ignore
         }
       } else {
         manager.activeWalletConnectionStatusStore.setValue("disconnected");