Merge branch 'main' of https://github.com/thirdweb-dev/js

Author: ianthirdweb

.changeset/cyan-shrimps-battle.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Update implementations

.changeset/fair-planes-doubt.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+SDK: Fix chain switching in smart account transactions

.changeset/metal-mails-ring.md

@@ -0,0 +1,20 @@
+---
+"thirdweb": patch
+---
+
+- Add onClose callback to Connect Details modal
+
+```tsx
+<ConnectButton
+  detailsModal={{
+    onClose: (screen: string) => {
+      // The last screen name that was being shown when user closed the modal
+      console.log({ screen });
+    }
+  }}
+/>
+```
+
+- Small fix for ChainIcon: Always resolve IPFS URI
+
+- Improve test coverage

.github/pull_request_template.md

@@ -1,4 +1,12 @@
-## Problem solved
+---
+title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
+---
 
-Short description of the bug fixed or feature added
+If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
+
+## Notes for the reviewer
+Anything important to call out? Be sure to also clarify these in your comments.
+
+## How to test
+Unit tests, playground, etc.
 

.github/workflows/auto-assign.yml

@@ -13,6 +13,7 @@ jobs:
     if: |
       github.event.pull_request.author_association == 'MEMBER' ||
       github.event.pull_request.author_association == 'OWNER' ||
-      github.event.pull_request.author_association == 'COLLABORATOR'
+      github.event.pull_request.author_association == 'COLLABORATOR' ||
+      github.event.pull_request.author_association == 'CONTRIBUTOR'
     steps:
       - uses: toshimaru/[email protected]

.github/workflows/issue.yml

@@ -5,7 +5,7 @@ on:
     types: [opened, edited, ready_for_review]
 
 env:
-  VALID_ISSUE_PREFIXES: "CORE|TOOL"
+  VALID_ISSUE_PREFIXES: "CORE|TOOL|NEB|INFRA"
 
 jobs:
   linear:

.github/workflows/stale.yml

@@ -9,7 +9,7 @@ jobs:
     steps:
       - uses: actions/stale@v9
         with:
-          stale-issue-message: 'This issue has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.'
-          stale-pr-message: 'This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.'
+          stale-issue-message: 'This issue has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.'
+          stale-pr-message: 'This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.'
           days-before-stale: 7
           days-before-close: 2

apps/dashboard/next-env.d.ts

@@ -3,4 +3,4 @@
 /// <reference types="next/navigation-types/compat/navigation" />
 
 // NOTE: This file should not be edited
-// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
+// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/list-form.tsx

@@ -18,6 +18,7 @@ import { CurrencySelector } from "components/shared/CurrencySelector";
 import { SolidityInput } from "contract-ui/components/solidity-inputs";
 import { useTrack } from "hooks/analytics/useTrack";
 import { useAllChainsData } from "hooks/chains/allChains";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { isAlchemySupported } from "lib/wallet/nfts/alchemy";
 import { isMoralisSupported } from "lib/wallet/nfts/moralis";
 import { isSimpleHashSupported } from "lib/wallet/nfts/simpleHash";
@@ -125,6 +126,15 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
     walletAddress: account?.address,
   });
   const sendAndConfirmTx = useSendAndConfirmTransaction();
+  const listingNotifications = useTxNotifications(
+    "NFT listed Successfully",
+    "Failed to list NFT",
+  );
+
+  const auctionNotifications = useTxNotifications(
+    "Auction created successfully",
+    "Failed to create an auction",
+  );
 
   const form = useForm<ListForm>({
     defaultValues:
@@ -351,14 +361,11 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
               endTimestamp,
             });
 
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => setOpen(false),
             });
-            toast.promise(promise, {
-              loading: "Listing NFT",
-              success: "NFT listed successfully",
-              error: "Failed to list NFT",
-            });
+
+            listingNotifications.onSuccess();
           } else if (formData.listingType === "auction") {
             let minimumBidAmountWei: bigint;
             let buyoutBidAmountWei: bigint;
@@ -403,7 +410,7 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
               buyoutBidAmountWei: buyoutBidAmountWei * selectedQuantity,
             });
 
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => {
                 trackEvent({
                   category: "marketplace",
@@ -423,15 +430,15 @@ export const CreateListingsForm: React.FC<CreateListingsFormProps> = ({
                 });
               },
             });
-            toast.promise(promise, {
-              loading: "Creating auction",
-              success: "Auction created successfully",
-              error: "Failed to create auction",
-            });
+            auctionNotifications.onSuccess();
           }
         } catch (err) {
           console.error(err);
-          toast.error("Failed to list NFT");
+          if (formData.listingType === "auction") {
+            auctionNotifications.onError(err);
+          } else {
+            listingNotifications.onError(err);
+          }
         }
 
         setIsFormLoading(false);

apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/airdrop-tab.tsx

@@ -12,6 +12,7 @@ import { cn } from "@/lib/utils";
 import type { Account } from "@3rdweb-sdk/react/hooks/useApi";
 import { TransactionButton } from "components/buttons/TransactionButton";
 import { useTrack } from "hooks/analytics/useTrack";
+import { useTxNotifications } from "hooks/useTxNotifications";
 import { UploadIcon } from "lucide-react";
 import { useState } from "react";
 import { useForm } from "react-hook-form";
@@ -49,6 +50,10 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
   const sendAndConfirmTx = useSendAndConfirmTransaction();
   const addresses = watch("addresses");
   const [open, setOpen] = useState(false);
+  const airdropNotifications = useTxNotifications(
+    "NFTs airdropped successfully",
+    "Failed to airdrop NFTs",
+  );
 
   return (
     <div className="flex w-full flex-col gap-2">
@@ -86,7 +91,7 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
               }),
             );
             const transaction = multicall({ contract, data });
-            const promise = sendAndConfirmTx.mutateAsync(transaction, {
+            await sendAndConfirmTx.mutateAsync(transaction, {
               onSuccess: () => {
                 trackEvent({
                   category: "nft",
@@ -108,14 +113,11 @@ const AirdropTab: React.FC<AirdropTabProps> = ({
                 });
               },
             });
-            toast.promise(promise, {
-              loading: "Airdropping NFTs",
-              success: "Airdropped successfully",
-              error: "Failed to airdrop",
-            });
+
+            airdropNotifications.onSuccess();
           } catch (err) {
             console.error(err);
-            toast.error("Failed to airdrop NFTs");
+            airdropNotifications.onError(err);
           }
         })}
       >