fix: updated createToken to just return a prepared tx

Author: gregfromstl

packages/thirdweb/src/tokens/create-token.ts

@@ -1,9 +1,6 @@
 import { bytesToHex, randomBytes } from "@noble/hashes/utils";
 import type { Hex } from "viem";
-import { parseEventLogs } from "../event/actions/parse-logs.js";
-import { createdEvent } from "../extensions/tokens/__generated__/ERC20Entrypoint/events/Created.js";
 import { createById } from "../extensions/tokens/__generated__/ERC20Entrypoint/write/createById.js";
-import { sendAndConfirmTransaction } from "../transaction/actions/send-and-confirm-transaction.js";
 import { padHex, toHex } from "../utils/encoding/hex.js";
 import { DEFAULT_DEVELOPER_ADDRESS } from "./constants.js";
 import { getDeployedEntrypointERC20 } from "./get-entrypoint-erc20.js";
@@ -15,9 +12,9 @@ import {
 import type { CreateTokenOptions } from "./types.js";
 
 export async function createToken(options: CreateTokenOptions) {
-  const { client, account, params, launchConfig } = options;
+  const { client, params, launchConfig } = options;
 
-  const creator = params.owner || account.address;
+  const creator = params.owner;
   const encodedInitData = await encodeInitParams({
     client,
     creator,
@@ -47,18 +44,5 @@ export async function createToken(options: CreateTokenOptions) {
     creator,
   });
 
-  const receipt = await sendAndConfirmTransaction({ account, transaction });
-  const assetEvent = createdEvent();
-  const decodedEvent = parseEventLogs({
-    events: [assetEvent],
-    logs: receipt.logs,
-  });
-
-  if (decodedEvent.length === 0 || !decodedEvent[0]) {
-    throw new Error(
-      `No AssetCreated event found in transaction: ${receipt.transactionHash}`,
-    );
-  }
-
-  return decodedEvent[0]?.args.asset;
+  return transaction;
 }

packages/thirdweb/src/tokens/types.ts

@@ -1,6 +1,9 @@
 import type { Hex } from "viem";
 import type { FileOrBufferOrString } from "../storage/upload/types.js";
-import type { ClientAndChainAndAccount } from "../utils/types.js";
+import type {
+  ClientAndChainAndAccount,
+  ClientAndChain,
+} from "../utils/types.js";
 
 export type TokenParams = {
   name: string;
@@ -11,7 +14,7 @@ export type TokenParams = {
   symbol?: string;
   contractURI?: string;
   maxSupply: bigint;
-  owner?: string;
+  owner: string;
 };
 
 export type PoolConfig = {
@@ -35,7 +38,7 @@ type LaunchConfig =
   | { kind: "pool"; config: PoolConfig }
   | { kind: "distribute"; config: DistributeConfig };
 
-export type CreateTokenOptions = ClientAndChainAndAccount & {
+export type CreateTokenOptions = ClientAndChain & {
   salt?: Hex;
   params: TokenParams;
   launchConfig?: LaunchConfig;
@@ -44,6 +47,6 @@ export type CreateTokenOptions = ClientAndChainAndAccount & {
 
 export type CreateTokenByImplementationConfigOptions =
   ClientAndChainAndAccount &
-    CreateTokenOptions & {
-      implementationAddress: string;
-    };
+  CreateTokenOptions & {
+    implementationAddress: string;
+  };