[thirdweb] fix: Update contract ABI caching strategy

Author: joaquim-verges

.changeset/thick-bees-deny.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Change caching strategy for contract ABI

.github/workflows/CI.yml

@@ -20,7 +20,7 @@ env:
 
 jobs:
   optimize_ci:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     outputs:
       skip: ${{ steps.check_skip.outputs.skip }}
     steps:
@@ -34,7 +34,7 @@ jobs:
   build:
     needs: optimize_ci
     if: needs.optimize_ci.outputs.skip == 'false'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     name: Build Packages
     steps:
       - name: Check out the code
@@ -51,7 +51,7 @@ jobs:
     if: needs.optimize_ci.outputs.skip == 'false'
     timeout-minutes: 15
     name: Lint Packages
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     steps:
       - name: Check out the code
         uses: actions/checkout@v4
@@ -71,7 +71,7 @@ jobs:
     if: needs.optimize_ci.outputs.skip == 'false'
     timeout-minutes: 15
     name: Unit Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     steps:
       - name: Check out the code
         uses: actions/checkout@v4
@@ -99,7 +99,7 @@ jobs:
     if: needs.optimize_ci.outputs.skip == 'false'
     timeout-minutes: 15
     name: E2E Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     strategy:
       matrix:
         package_manager: [npm, yarn, pnpm, bun]
@@ -169,7 +169,7 @@ jobs:
     if:  github.event_name == 'pull_request' && needs.optimize_ci.outputs.skip == 'false'
     timeout-minutes: 15
     name: "Size"
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8
     steps:
       - name: Check out the code
         uses: actions/checkout@v4

packages/thirdweb/src/contract/actions/resolve-abi.ts

@@ -1,9 +1,10 @@
 import { type Abi, formatAbi, parseAbi } from "abitype";
 import { download } from "../../storage/download.js";
+import { LruMap } from "../../utils/caching/lru.js";
 import { getClientFetch } from "../../utils/fetch.js";
 import { type ThirdwebContract, getContract } from "../contract.js";
 
-const ABI_RESOLUTION_CACHE = new WeakMap<ThirdwebContract<Abi>, Promise<Abi>>();
+const ABI_RESOLUTION_CACHE = new LruMap<Promise<Abi>>(256);
 
 /**
  * Resolves the ABI (Application Binary Interface) for a given contract.
@@ -32,8 +33,9 @@ export function resolveContractAbi<abi extends Abi>(
   contract: ThirdwebContract<abi>,
   contractApiBaseUrl = "https://contract.thirdweb.com/abi",
 ): Promise<abi> {
-  if (ABI_RESOLUTION_CACHE.has(contract)) {
-    return ABI_RESOLUTION_CACHE.get(contract) as Promise<abi>;
+  const key = `${contract.chain.id}-${contract.address}`;
+  if (ABI_RESOLUTION_CACHE.has(key)) {
+    return ABI_RESOLUTION_CACHE.get(key) as Promise<abi>;
   }
 
   const prom = (async () => {
@@ -55,7 +57,7 @@ export function resolveContractAbi<abi extends Abi>(
       return await resolveCompositeAbi(contract as ThirdwebContract);
     }
   })();
-  ABI_RESOLUTION_CACHE.set(contract, prom);
+  ABI_RESOLUTION_CACHE.set(key, prom);
   return prom as Promise<abi>;
 }