test(sdk): deployErc721

Author: gregfromstl

.changeset/selfish-deers-destroy.md

@@ -2,26 +2,10 @@
 "thirdweb": minor
 ---
 
-Adds Multiwrap and LoyaltyCard support to ERC721 deployment.
+Adds LoyaltyCard extensions and support for ERC721 deployment.
 
 ```ts
 import { deployERC721Contract } from "thirdweb/deploys";
-const multiwrapContractAddress = await deployERC721Contract({
-    chain: "your-chain-id", // replace with your chain ID
-    client: yourThirdwebClient, // replace with your Thirdweb client instance
-    account: yourAccount, // replace with your account details
-    type: "Multiwrap",
-    params: {
-        name: "MyMultiwrapNFT",
-        symbol: "MWNFT",
-        description: "A multiwrap NFT contract",
-        image: "path/to/image.png", // replace with your image path
-        defaultAdmin: "0xYourAdminAddress", // replace with your admin address
-        royaltyRecipient: "0xYourRoyaltyRecipient", // replace with your royalty recipient address
-        royaltyBps: 500n, // 5% royalty
-        trustedForwarders: ["0xTrustedForwarderAddress"], // replace with your trusted forwarder addresses
-    },
-});
 
 const loyaltyCardContractAddress = await deployERC721Contract({
     chain: "your-chain-id", // replace with your chain ID

codecov.yml

@@ -8,6 +8,8 @@ coverage:
         target: 80%
         flags:
           - packages
+        ignore:
+          - "**/__generated__/**"
 
 
 github_checks:

packages/thirdweb/src/extensions/prebuilts/deploy-erc721.test.ts

@@ -8,8 +8,6 @@ import { deployERC721Contract } from "./deploy-erc721.js";
 
 const account = TEST_ACCOUNT_B;
 
-// skip this test suite if there is no secret key available to test with
-// TODO: remove reliance on secret key during unit tests entirely
 describe.runIf(process.env.TW_SECRET_KEY)("deployERC721", () => {
   it("should deploy ERC721 open edition", async () => {
     const address = await deployERC721Contract({
@@ -21,6 +19,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("deployERC721", () => {
         name: "OE",
       },
     });
+
     expect(address).toBeDefined();
     const deployedName = await name({
       contract: getContract({
@@ -31,4 +30,73 @@ describe.runIf(process.env.TW_SECRET_KEY)("deployERC721", () => {
     });
     expect(deployedName).toBe("OE");
   });
+
+  it("should deploy ERC721 drop", async () => {
+    const address = await deployERC721Contract({
+      client: TEST_CLIENT,
+      chain: ANVIL_CHAIN,
+      account,
+      type: "DropERC721",
+      params: {
+        name: "Drop",
+        symbol: "DRP",
+      },
+    });
+
+    expect(address).toBeDefined();
+    const deployedName = await name({
+      contract: getContract({
+        client: TEST_CLIENT,
+        chain: ANVIL_CHAIN,
+        address,
+      }),
+    });
+    expect(deployedName).toBe("Drop");
+  });
+
+  it("should deploy ERC721 token", async () => {
+    const address = await deployERC721Contract({
+      client: TEST_CLIENT,
+      chain: ANVIL_CHAIN,
+      account,
+      type: "TokenERC721",
+      params: {
+        name: "Token",
+        symbol: "TKN",
+      },
+    });
+
+    expect(address).toBeDefined();
+    const deployedName = await name({
+      contract: getContract({
+        client: TEST_CLIENT,
+        chain: ANVIL_CHAIN,
+        address,
+      }),
+    });
+    expect(deployedName).toBe("Token");
+  });
+
+  it("should deploy ERC721 loyalty card", async () => {
+    const address = await deployERC721Contract({
+      client: TEST_CLIENT,
+      chain: ANVIL_CHAIN,
+      account,
+      type: "LoyaltyCard",
+      params: {
+        name: "Loyalty",
+        symbol: "LOY",
+      },
+    });
+
+    expect(address).toBeDefined();
+    const deployedName = await name({
+      contract: getContract({
+        client: TEST_CLIENT,
+        chain: ANVIL_CHAIN,
+        address,
+      }),
+    });
+    expect(deployedName).toBe("Loyalty");
+  });
 });

packages/thirdweb/src/extensions/prebuilts/deploy-erc721.ts

@@ -7,7 +7,6 @@ import type { FileOrBufferOrString } from "../../storage/upload/types.js";
 import type { Prettify } from "../../utils/type-utils.js";
 import type { ClientAndChainAndAccount } from "../../utils/types.js";
 import { initialize as initLoyaltyCard } from "../erc721/__generated__/LoyaltyCard/write/initialize.js";
-import { initialize as initMultiwrap } from "../erc721/__generated__/Multiwrap/write/initialize.js";
 import { initialize as initDropERC721 } from "./__generated__/DropERC721/write/initialize.js";
 import { initialize as initOpenEditionERC721 } from "./__generated__/OpenEditionERC721/write/initialize.js";
 import { initialize as initTokenERC721 } from "./__generated__/TokenERC721/write/initialize.js";
@@ -19,7 +18,6 @@ export type ERC721ContractType =
   | "DropERC721"
   | "TokenERC721"
   | "OpenEditionERC721"
-  | "Multiwrap"
   | "LoyaltyCard";
 
 /**
@@ -171,17 +169,6 @@ async function getInitializeTransaction(options: {
         royaltyBps: params.royaltyBps || 0n,
         trustedForwarders: params.trustedForwarders || [],
       });
-    case "Multiwrap":
-      return initMultiwrap({
-        contract: implementationContract,
-        defaultAdmin: params.defaultAdmin || accountAddress,
-        name: params.name || "",
-        symbol: params.symbol || "",
-        contractURI,
-        royaltyRecipient: params.royaltyRecipient || accountAddress,
-        royaltyBps: params.royaltyBps || 0n,
-        trustedForwarders: params.trustedForwarders || [],
-      });
     case "LoyaltyCard":
       return initLoyaltyCard({
         contract: implementationContract,