Skip to content

Commit bdf6b8e

Browse files
committed
address rabbit and feedback
1 parent 6f2ff32 commit bdf6b8e

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/_common/download-file-button.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ export function handleDownload(params: {
1010
const blob = new Blob([params.fileContent], {
1111
type: params.fileFormat,
1212
});
13-
link.href = URL.createObjectURL(blob);
13+
const objectURL = URL.createObjectURL(blob);
14+
link.href = objectURL;
1415
link.download = params.fileNameWithExtension;
1516
link.click();
17+
URL.revokeObjectURL(objectURL);
1618
}
1719

1820
export function DownloadFileButton(props: {

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/_common/schema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const socialUrlsSchema = z.array(
1313
}
1414

1515
const url = val.startsWith("http") ? val : `https://${val}`;
16-
return urlSchema.safeParse(url);
16+
return urlSchema.safeParse(url).success;
1717
},
1818
{
1919
message: "Invalid URL",

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/create-nft-page.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,20 +148,22 @@ export function CreateNFTPage(props: {
148148
trackEvent(
149149
getNFTStepTrackingData({
150150
action: "deploy",
151-
ercType: "erc721",
151+
ercType,
152152
chainId: Number(formValues.chain),
153153
status: "success",
154154
}),
155155
);
156156

157157
trackEvent(
158158
getNFTDeploymentTrackingData({
159-
ercType: "erc721",
159+
ercType,
160160
type: "success",
161161
chainId: Number(formValues.chain),
162162
}),
163163
);
164164

165+
contractAddressRef.current = contractAddress;
166+
165167
// add contract to project in background
166168
addContractToProject.mutateAsync({
167169
teamId: props.teamId,
@@ -172,8 +174,6 @@ export function CreateNFTPage(props: {
172174
contractType: ercType === "erc721" ? "DropERC721" : "DropERC1155",
173175
});
174176

175-
contractAddressRef.current = contractAddress;
176-
177177
return {
178178
contractAddress,
179179
};
@@ -184,7 +184,7 @@ export function CreateNFTPage(props: {
184184
trackEvent(
185185
getNFTStepTrackingData({
186186
action: "deploy",
187-
ercType: "erc721",
187+
ercType,
188188
chainId: Number(formValues.chain),
189189
status: "error",
190190
errorMessage,
@@ -193,7 +193,7 @@ export function CreateNFTPage(props: {
193193

194194
trackEvent(
195195
getNFTDeploymentTrackingData({
196-
ercType: "erc721",
196+
ercType,
197197
type: "error",
198198
chainId: Number(formValues.chain),
199199
errorMessage,

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/upload-nfts/single-upload/single-upload-nft.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export function SingleUploadNFT(props: {
175175
>
176176
<Input
177177
id="name"
178-
placeholder="My NFT Collection"
178+
placeholder="My NFT"
179179
{...form.register("name")}
180180
/>
181181
</FormFieldSetup>
@@ -189,7 +189,7 @@ export function SingleUploadNFT(props: {
189189
>
190190
<Textarea
191191
id="description"
192-
placeholder="Describe your NFT collection"
192+
placeholder="Describe your NFT"
193193
className="grow"
194194
{...form.register("description")}
195195
/>

0 commit comments

Comments
 (0)