test(sdk): parse-typed-data

Author: gregfromstl

packages/thirdweb/src/utils/signatures/helpers/parse-typed-data.test.ts

@@ -0,0 +1,56 @@
+import { describe, expect, test } from "vitest";
+import { parseTypedData } from "./parse-typed-data.js";
+
+describe("parseTypedData", () => {
+  test("parses typed data with hex chainId", () => {
+    const typedData = {
+      domain: {
+        chainId: "0x1" as unknown as number,
+      },
+      types: {},
+      primaryType: "EIP712Domain" as const,
+    };
+
+    const result = parseTypedData(typedData);
+    expect(result.domain.chainId).toBe(1);
+  });
+
+  test("returns typed data unchanged if chainId is not hex", () => {
+    const typedData = {
+      domain: {
+        chainId: 1,
+      },
+      types: {},
+      primaryType: "EIP712Domain" as const,
+    };
+
+    const result = parseTypedData(typedData);
+    expect(result.domain.chainId).toBe(1);
+  });
+
+  test("returns typed data unchanged if chainId is undefined", () => {
+    const typedData = {
+      domain: {},
+      types: {},
+      primaryType: "EIP712Domain" as const,
+    };
+
+    const result = parseTypedData(typedData);
+    expect(result.domain.chainId).toBeUndefined();
+  });
+
+  test("handles unknown domain properties", () => {
+    const typedData = {
+      domain: {
+        chainId: "0x1" as unknown as number,
+        name: "Test",
+      },
+      types: {},
+      primaryType: "EIP712Domain" as const,
+    };
+
+    const result = parseTypedData(typedData);
+    expect(result.domain.chainId).toBe(1);
+    expect(result.domain.name).toBe("Test");
+  });
+});

packages/thirdweb/src/utils/signatures/helpers/parseTypedData.ts renamed to packages/thirdweb/src/utils/signatures/helpers/parse-typed-data.ts

@@ -1,7 +1,7 @@
 import type { TypedData } from "abitype";
 import { type TypedDataDefinition, hashTypedData } from "viem";
 import type { Hex } from "../encoding/hex.js";
-import { parseTypedData } from "./helpers/parseTypedData.js";
+import { parseTypedData } from "./helpers/parse-typed-data.js";
 import { sign } from "./sign.js";
 import { signatureToHex } from "./signature-to-hex.js";
 

packages/thirdweb/src/utils/signatures/sign-typed-data.ts

@@ -25,7 +25,7 @@ import {
   stringToHex,
   uint8ArrayToHex,
 } from "../../utils/encoding/hex.js";
-import { parseTypedData } from "../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../utils/signatures/helpers/parse-typed-data.js";
 import { COINBASE } from "../constants.js";
 import type {
   GetCallsStatusResponse,

packages/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts

@@ -6,7 +6,7 @@ import { eth_sendRawTransaction } from "../../../../rpc/actions/eth_sendRawTrans
 import { getRpcClient } from "../../../../rpc/rpc.js";
 import { getAddress } from "../../../../utils/address.js";
 import { type Hex, toHex } from "../../../../utils/encoding/hex.js";
-import { parseTypedData } from "../../../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../../../utils/signatures/helpers/parse-typed-data.js";
 import type { Prettify } from "../../../../utils/type-utils.js";
 import type {
   Account,

packages/thirdweb/src/wallets/in-app/core/wallet/enclave-wallet.ts

@@ -8,7 +8,7 @@ import { getRpcClient } from "../../../../rpc/rpc.js";
 import { getAddress } from "../../../../utils/address.js";
 import { getThirdwebDomains } from "../../../../utils/domains.js";
 import { type Hex, hexToString } from "../../../../utils/encoding/hex.js";
-import { parseTypedData } from "../../../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../../../utils/signatures/helpers/parse-typed-data.js";
 import type { Prettify } from "../../../../utils/type-utils.js";
 import type {
   Account,

packages/thirdweb/src/wallets/in-app/web/lib/iframe-wallet.ts

@@ -16,7 +16,7 @@ import {
   stringToHex,
   uint8ArrayToHex,
 } from "../../utils/encoding/hex.js";
-import { parseTypedData } from "../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../utils/signatures/helpers/parse-typed-data.js";
 import type { InjectedSupportedWalletIds } from "../__generated__/wallet-ids.js";
 import type { Account, SendTransactionOption } from "../interfaces/wallet.js";
 import type { DisconnectFn, SwitchChainFn } from "../types.js";

packages/thirdweb/src/wallets/injected/index.ts

@@ -24,7 +24,7 @@ import { getAddress } from "../../utils/address.js";
 import { isZkSyncChain } from "../../utils/any-evm/zksync/isZkSyncChain.js";
 import { concatHex } from "../../utils/encoding/helpers/concat-hex.js";
 import type { Hex } from "../../utils/encoding/hex.js";
-import { parseTypedData } from "../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../utils/signatures/helpers/parse-typed-data.js";
 import type {
   Account,
   SendTransactionOption,

packages/thirdweb/src/wallets/smart/index.ts

@@ -25,7 +25,7 @@ import {
   uint8ArrayToHex,
 } from "../../utils/encoding/hex.js";
 import { stringify } from "../../utils/json.js";
-import { parseTypedData } from "../../utils/signatures/helpers/parseTypedData.js";
+import { parseTypedData } from "../../utils/signatures/helpers/parse-typed-data.js";
 import type { AsyncStorage } from "../../utils/storage/AsyncStorage.js";
 import {
   getSavedConnectParamsFromStorage,