fixup! feat(sdk): makes chain optional in smart wallet config

Author: gregfromstl

packages/thirdweb/src/wallets/smart/lib/calls.ts

@@ -1,4 +1,5 @@
 import type { Chain } from "../../../chains/types.js";
+import { getCachedChain } from "../../../chains/utils.js";
 import type { ThirdwebClient } from "../../../client/client.js";
 import {
   type ThirdwebContract,
@@ -29,7 +30,7 @@ import { DEFAULT_ACCOUNT_FACTORY_V0_6 } from "./constants.js";
  */
 export async function predictSmartAccountAddress(args: {
   client: ThirdwebClient;
-  chain: Chain;
+  chain?: Chain;
   adminAddress: string;
   factoryAddress?: string;
   accountSalt?: string;
@@ -39,7 +40,7 @@ export async function predictSmartAccountAddress(args: {
     accountSalt: args.accountSalt,
     factoryContract: getContract({
       address: args.factoryAddress ?? DEFAULT_ACCOUNT_FACTORY_V0_6,
-      chain: args.chain,
+      chain: args.chain ?? getCachedChain(1),
       client: args.client,
     }),
   });

packages/thirdweb/src/wallets/smart/smart-wallet-integration-v07.test.ts

@@ -77,7 +77,31 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       });
     });
 
-    it("can connect", async () => {
+    it("can deploy with default chain", async () => {
+      const wallet = smartWallet({
+        gasless: true,
+        factoryAddress: DEFAULT_ACCOUNT_FACTORY_V0_7,
+      });
+      const smartAccount = await wallet.connect({
+        client: TEST_CLIENT,
+        personalAccount,
+      });
+      expect(smartAccount.address).toHaveLength(42);
+
+      const signature = await smartAccount.signMessage({
+        message: "hello world",
+      });
+      const isValid = await verifySignature({
+        message: "hello world",
+        signature,
+        address: smartWalletAddress,
+        chain: wallet.getChain(),
+        client,
+      });
+      expect(isValid).toEqual(true);
+    });
+
+    it("can predict account address", async () => {
       expect(smartWalletAddress).toHaveLength(42);
       const predictedAddress = await predictSmartAccountAddress({
         client,
@@ -88,6 +112,15 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       expect(predictedAddress).toEqual(smartWalletAddress);
     });
 
+    it("can predict account address with default chain", async () => {
+      const predictedAddress = await predictSmartAccountAddress({
+        client,
+        adminAddress: personalAccount.address,
+        factoryAddress: DEFAULT_ACCOUNT_FACTORY_V0_7,
+      });
+      expect(predictedAddress).toEqual(smartWalletAddress);
+    });
+
     it("can sign a msg", async () => {
       const signature = await smartAccount.signMessage({
         message: "hello world",

packages/thirdweb/src/wallets/smart/smart-wallet-integration.test.ts

@@ -74,7 +74,29 @@ describe.runIf(process.env.TW_SECRET_KEY).sequential(
       });
     });
 
-    it("can connect", async () => {
+    it("can deploy with default chain", async () => {
+      const wallet = smartWallet({
+        gasless: true,
+      });
+      const smartAccount = await wallet.connect({
+        client: TEST_CLIENT,
+        personalAccount,
+      });
+      expect(smartAccount.address).toHaveLength(42);
+      const signature = await smartAccount.signMessage({
+        message: "hello world",
+      });
+      const isValid = await verifySignature({
+        message: "hello world",
+        signature,
+        address: smartWalletAddress,
+        chain: wallet.getChain(),
+        client,
+      });
+      expect(isValid).toEqual(true);
+    });
+
+    it("can predict account address", async () => {
       expect(smartWalletAddress).toHaveLength(42);
       const predictedAddress = await predictSmartAccountAddress({
         client,
@@ -84,6 +106,14 @@ describe.runIf(process.env.TW_SECRET_KEY).sequential(
       expect(predictedAddress).toEqual(smartWalletAddress);
     });
 
+    it("can predict account address with default chain", async () => {
+      const predictedAddress = await predictSmartAccountAddress({
+        client,
+        adminAddress: personalAccount.address,
+      });
+      expect(predictedAddress).toEqual(smartWalletAddress);
+    });
+
     it("can sign a msg", async () => {
       const signature = await smartAccount.signMessage({
         message: "hello world",