address review

Author: 0xFirekeeper

packages/thirdweb/src/exports/extensions/erc7702.ts

@@ -23,3 +23,10 @@ export {
 } from "../../wallets/in-app/native/auth/index.js";
 export { hasStoredPasskey } from "../../wallets/in-app/native/auth/passkeys.js";
 export { inAppWallet } from "../../wallets/in-app/native/in-app.js";
+
+//ACCOUNT
+export {
+  type CreateSessionKeyOptions,
+  createSessionKey,
+  isCreateSessionKeySupported,
+} from "../../extensions/erc7702/account/createSessionKey.js";

packages/thirdweb/src/exports/wallets/in-app.native.ts

@@ -27,3 +27,10 @@ export {
   unlinkProfile,
 } from "../../wallets/in-app/web/lib/auth/index.js";
 export { hasStoredPasskey } from "../../wallets/in-app/web/lib/auth/passkeys.js";
+
+//ACCOUNT
+export {
+  type CreateSessionKeyOptions,
+  createSessionKey,
+  isCreateSessionKeySupported,
+} from "../../extensions/erc7702/account/createSessionKey.js";

packages/thirdweb/src/exports/wallets/in-app.ts

@@ -26,7 +26,7 @@ export type CreateSessionKeyOptions = {
   /**
    * The address to add as a session key.
    */
-  sessionKeyAddress: `0x${string}`;
+  sessionKeyAddress: string;
   /**
    * How long the session key should be valid for, in seconds.
    */
@@ -89,9 +89,13 @@ export function createSessionKey(
       const req = {
         callPolicies: (callPolicies || []).map((policy) => ({
           constraints: (policy.constraints || []).map((constraint) => ({
-            condition: constraint.condition,
+            condition: Number(constraint.condition),
             index: constraint.index || BigInt(0),
-            limit: constraint.limit || {
+            limit: constraint.limit ? {
+              limit: constraint.limit.limit,
+              limitType: Number(constraint.limit.limitType),
+              period: constraint.limit.period,
+            } : {
               limit: BigInt(0),
               limitType: 0,
               period: BigInt(0),
@@ -101,7 +105,11 @@ export function createSessionKey(
           maxValuePerUse: policy.maxValuePerUse || BigInt(0),
           selector: policy.selector,
           target: policy.target,
-          valueLimit: policy.valueLimit || {
+          valueLimit: policy.valueLimit ? {
+            limit: policy.valueLimit.limit,
+            limitType: Number(policy.valueLimit.limitType),
+            period: policy.valueLimit.period,
+          } : {
             limit: BigInt(0),
             limitType: 0,
             period: BigInt(0),
@@ -113,7 +121,11 @@ export function createSessionKey(
         transferPolicies: (transferPolicies || []).map((policy) => ({
           maxValuePerUse: policy.maxValuePerUse || BigInt(0),
           target: policy.target,
-          valueLimit: policy.valueLimit || {
+          valueLimit: policy.valueLimit ? {
+            limit: policy.valueLimit.limit,
+            limitType: Number(policy.valueLimit.limitType),
+            period: policy.valueLimit.period,
+          } : {
             limit: BigInt(0),
             limitType: 0,
             period: BigInt(0),

packages/thirdweb/src/extensions/erc7702/account/createSessionKey.ts

@@ -1,17 +1,37 @@
+/* ────────────────────────────────
+   Enums
+   ──────────────────────────────── */
+
+export enum LimitType {
+  Unlimited = 0,
+  Lifetime = 1,
+  Allowance = 2
+}
+
+export enum Condition {
+  Unconstrained = 0,
+  Equal = 1,
+  Greater = 2,
+  Less = 3,
+  GreaterOrEqual = 4,
+  LessOrEqual = 5,
+  NotEqual = 6
+}
+
 /* ────────────────────────────────
    Input types
    ──────────────────────────────── */
 
 /* ---------- UsageLimit ---------- */
 interface UsageLimitInput {
-  limitType: number;
+  limitType: LimitType;
   limit: bigint;
   period: bigint;
 }
 
 /* ---------- Constraint ---------- */
 interface ConstraintInput {
-  condition: number;
+  condition: Condition;
   index: bigint;
   refValue: `0x${string}`;
   limit?: UsageLimitInput;