fix(sdk): stricter console checks

Author: gregfromstl

packages/thirdweb/biome.json

@@ -7,7 +7,12 @@
         "noProcessEnv": "warn"
       },
       "suspicious": {
-        "noConsoleLog": "error"
+        "noConsole": {
+          "level": "error",
+          "options": {
+            "allow": ["error", "warn"]
+          }
+        }
       }
     }
   },
@@ -21,6 +26,16 @@
           }
         }
       }
+    },
+    {
+      "include": ["src/cli/bin.ts", "src/cli/commands/**"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noConsole": "off"
+          }
+        }
+      }
     }
   ],
   "files": {

packages/thirdweb/src/wallets/smart/lib/bundler.ts

@@ -17,7 +17,6 @@ import {
   formatUserOperationReceipt,
 } from "../types.js";
 import {
-  DEBUG,
   ENTRYPOINT_ADDRESS_v0_6,
   MANAGED_ACCOUNT_GAS_BUFFER,
   getDefaultBundlerUrl,
@@ -267,10 +266,6 @@ async function sendBundlerRequest(args: {
 }) {
   const { options, operation, params } = args;
 
-  if (DEBUG) {
-    console.debug(`>>> sending ${operation} with payload:`, params);
-  }
-
   const bundlerUrl = options.bundlerUrl ?? getDefaultBundlerUrl(options.chain);
   const fetchWithHeaders = getClientFetch(options.client);
   const response = await fetchWithHeaders(bundlerUrl, {
@@ -301,9 +296,5 @@ Code: ${code}`,
     );
   }
 
-  if (DEBUG) {
-    console.debug(`<<< ${operation} result:`, res);
-  }
-
   return res.result;
 }

packages/thirdweb/src/wallets/smart/lib/constants.ts

@@ -2,9 +2,6 @@ import type { Chain } from "../../../chains/types.js";
 import { getAddress } from "../../../utils/address.js";
 import { getThirdwebDomains } from "../../../utils/domains.js";
 
-// dev only
-export const DEBUG = false;
-
 export const DUMMY_SIGNATURE =
   "0xfffffffffffffffffffffffffffffff0000000000000000000000000000000007aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa1c";
 

packages/thirdweb/src/wallets/smart/lib/paymaster.ts

@@ -8,11 +8,7 @@ import type {
   UserOperationV06,
   UserOperationV07,
 } from "../types.js";
-import {
-  DEBUG,
-  ENTRYPOINT_ADDRESS_v0_6,
-  getDefaultBundlerUrl,
-} from "./constants.js";
+import { ENTRYPOINT_ADDRESS_v0_6, getDefaultBundlerUrl } from "./constants.js";
 import { hexlifyUserOp } from "./utils.js";
 
 /**
@@ -80,10 +76,6 @@ Code: ${code}`,
     );
   }
 
-  if (DEBUG) {
-    console.debug("Paymaster result:", res);
-  }
-
   if (res.result) {
     // some paymasters return a string, some return an object with more data
     if (typeof res.result === "string") {