SDK: do not attempt autoconnect again if already successfull (#6900)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `force` option for the auto-connect functionality in the `thirdweb` wallet, allowing users to force an auto-connect attempt even if a previous attempt was successful.

### Detailed summary
- Added `force` option to `AutoConnectProps` in `autoConnect.ts`.
- Updated `autoConnectCore` to respect the `force` option, allowing multiple connect attempts.
- Modified tests in `autoConnectCore.test.ts` to include the `force` option in various scenarios.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

Author: MananTank

.changeset/odd-rooms-sleep.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+Only attempt autoconnect once

packages/thirdweb/src/wallets/connection/autoConnect.ts

@@ -32,6 +32,12 @@ import type { AutoConnectProps } from "./types.js";
 export async function autoConnect(
   props: AutoConnectProps & {
     wallets?: Wallet[];
+    /**
+     * If true, the auto connect will be forced even if autoConnect has already been attempted successfully earlier.
+     *
+     * @default `false`
+     */
+    force?: boolean;
   },
 ): Promise<boolean> {
   const wallets = props.wallets || getDefaultWallets(props);

packages/thirdweb/src/wallets/connection/autoConnectCore.test.ts

@@ -35,6 +35,7 @@ describe("useAutoConnectCore", () => {
 
     expect(
       await autoConnectCore({
+        force: true,
         storage: mockStorage,
         props: {
           wallets: [wallet],
@@ -68,6 +69,7 @@ describe("useAutoConnectCore", () => {
 
     expect(
       await autoConnectCore({
+        force: true,
         storage: mockStorage,
         props: {
           wallets: [wallet],
@@ -111,6 +113,7 @@ describe("useAutoConnectCore", () => {
       });
 
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],
@@ -155,6 +158,7 @@ describe("useAutoConnectCore", () => {
     });
 
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],
@@ -191,6 +195,7 @@ describe("useAutoConnectCore", () => {
     const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
 
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet1],
@@ -235,6 +240,7 @@ describe("useAutoConnectCore", () => {
     const addConnectedWalletSpy = vi.spyOn(manager, "addConnectedWallet");
 
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet1, wallet2],
@@ -264,6 +270,7 @@ describe("useAutoConnectCore", () => {
       JSON.stringify([wallet.id]),
     );
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],
@@ -276,6 +283,7 @@ describe("useAutoConnectCore", () => {
 
     expect(mockOnConnect).toHaveBeenCalledWith(wallet);
   });
+
   it("should continue even if onConnect callback throws", async () => {
     const mockOnConnect = vi.fn();
     mockOnConnect.mockImplementation(() => {
@@ -296,6 +304,7 @@ describe("useAutoConnectCore", () => {
       JSON.stringify([wallet.id]),
     );
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],
@@ -308,6 +317,7 @@ describe("useAutoConnectCore", () => {
 
     expect(mockOnConnect).toHaveBeenCalledWith(wallet);
   });
+
   it("should call setLastAuthProvider if authProvider is present", async () => {
     const wallet = createWalletAdapter({
       adaptedAccount: TEST_ACCOUNT_A,
@@ -328,6 +338,7 @@ describe("useAutoConnectCore", () => {
       JSON.stringify([wallet.id]),
     );
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],
@@ -340,6 +351,7 @@ describe("useAutoConnectCore", () => {
 
     expect(mockSetLastAuthProvider).toHaveBeenCalledWith("email", mockStorage);
   });
+
   it("should set connection status to disconnect if no connectedWallet is returned", async () => {
     const wallet = createWalletAdapter({
       adaptedAccount: TEST_ACCOUNT_A,
@@ -360,6 +372,7 @@ describe("useAutoConnectCore", () => {
       .mockResolvedValueOnce(null as unknown as Wallet);
 
     await autoConnectCore({
+      force: true,
       storage: mockStorage,
       props: {
         wallets: [wallet],

packages/thirdweb/src/wallets/connection/autoConnectCore.ts

@@ -19,18 +19,7 @@ import {
 import type { WalletId } from "../wallet-types.js";
 import type { AutoConnectProps } from "./types.js";
 
-/**
- * @internal
- */
-export const autoConnectCore = async ({
-  storage,
-  props,
-  createWalletFn,
-  manager,
-  connectOverride,
-  getInstalledWallets,
-  setLastAuthProvider,
-}: {
+type AutoConnectCoreProps = {
   storage: AsyncStorage;
   props: AutoConnectProps & { wallets: Wallet[] };
   createWalletFn: (id: WalletId) => Wallet;
@@ -43,7 +32,45 @@ export const autoConnectCore = async ({
     authProvider: AuthArgsType["strategy"],
     storage: AsyncStorage,
   ) => Promise<void>;
-}): Promise<boolean> => {
+  /**
+   * If true, the auto connect will be forced even if autoConnect has already been attempted successfully earlier.
+   *
+   * @default `false`
+   */
+  force?: boolean;
+};
+
+let lastAutoConnectionResultPromise: Promise<boolean> | undefined = undefined;
+
+/**
+ * @internal
+ */
+export const autoConnectCore = async (props: AutoConnectCoreProps) => {
+  // if an auto connect was attempted already
+  if (lastAutoConnectionResultPromise && !props.force) {
+    // wait for its resolution
+    const lastResult = await lastAutoConnectionResultPromise;
+    // if it was successful, return true
+    // if not continue with the new auto connect
+    if (lastResult) {
+      return true;
+    }
+  }
+
+  const resultPromise = _autoConnectCore(props);
+  lastAutoConnectionResultPromise = resultPromise;
+  return resultPromise;
+};
+
+const _autoConnectCore = async ({
+  storage,
+  props,
+  createWalletFn,
+  manager,
+  connectOverride,
+  getInstalledWallets,
+  setLastAuthProvider,
+}: AutoConnectCoreProps): Promise<boolean> => {
   const { wallets, onConnect } = props;
   const timeout = props.timeout ?? 15000;