[SDK] feat: Add transfer success callback (#6415)

Author: joaquim-verges

.changeset/funny-eggs-hear.md

@@ -0,0 +1,5 @@
+---
+"thirdweb": patch
+---
+
+emit onPurchaseSuccess for wallet to wallet transfer flow before execution

apps/playground-web/src/components/in-app-wallet/ecosystem.tsx

@@ -3,24 +3,21 @@ import type { ConnectButtonProps } from "thirdweb/react";
 import { ecosystemWallet } from "thirdweb/wallets";
 import { StyledConnectEmbed } from "../styled-connect-embed";
 
-const getEcosystem = () => {
+const getEcosystemWallet = () => {
   if (
     process.env.NEXT_PUBLIC_IN_APP_WALLET_URL?.endsWith(".thirdweb-dev.com")
   ) {
     // dev ecosystem
-    return "ecosystem.catlovers";
+    return ecosystemWallet("ecosystem.catlovers");
   }
   // prod ecosystem
-  return "ecosystem.thirdweb-engs";
+  return ecosystemWallet("ecosystem.thirdweb-engs", {
+    partnerId: "50fd8850-3c6c-48dd-969c-622f88b52d95",
+  });
 };
 
 export function EcosystemConnectEmbed(
   props?: Omit<ConnectButtonProps, "client" | "theme">,
 ) {
-  return (
-    <StyledConnectEmbed
-      {...props}
-      wallets={[ecosystemWallet(getEcosystem())]}
-    />
-  );
+  return <StyledConnectEmbed {...props} wallets={[getEcosystemWallet()]} />;
 }

apps/playground-web/src/components/pay/transaction-button.tsx

@@ -35,7 +35,7 @@ export function PayTransactionPreview() {
   const { theme } = useTheme();
   const { data: nft } = useReadContract(getNFT, {
     contract: nftContract,
-    tokenId: 1n,
+    tokenId: 2n,
   });
 
   return (
@@ -51,7 +51,7 @@ export function PayTransactionPreview() {
             transaction: claimTo({
               contract: nftContract,
               quantity: 1n,
-              tokenId: 1n,
+              tokenId: 2n,
               to: account?.address || "",
             }),
             metadata: nft?.metadata,

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/TransferConfirmationScreen.tsx

@@ -6,12 +6,18 @@ import type { ThirdwebClient } from "../../../../../../../client/client.js";
 import { NATIVE_TOKEN_ADDRESS } from "../../../../../../../constants/addresses.js";
 import { getContract } from "../../../../../../../contract/contract.js";
 import { allowance } from "../../../../../../../extensions/erc20/__generated__/IERC20/read/allowance.js";
+import {
+  type GetCurrencyMetadataResult,
+  getCurrencyMetadata,
+} from "../../../../../../../extensions/erc20/read/getCurrencyMetadata.js";
 import { approve } from "../../../../../../../extensions/erc20/write/approve.js";
 import { transfer } from "../../../../../../../extensions/erc20/write/transfer.js";
+import type { BuyWithCryptoStatus } from "../../../../../../../pay/buyWithCrypto/getStatus.js";
 import { getBuyWithCryptoTransfer } from "../../../../../../../pay/buyWithCrypto/getTransfer.js";
 import { sendAndConfirmTransaction } from "../../../../../../../transaction/actions/send-and-confirm-transaction.js";
 import { sendTransaction } from "../../../../../../../transaction/actions/send-transaction.js";
 import { prepareTransaction } from "../../../../../../../transaction/prepare-transaction.js";
+import type { TransactionReceipt } from "../../../../../../../transaction/types.js";
 import type { Address } from "../../../../../../../utils/address.js";
 import { toWei } from "../../../../../../../utils/units.js";
 import { iconSize } from "../../../../../../core/design-system/index.js";
@@ -42,6 +48,7 @@ type TransferConfirmationScreenProps = {
   tokenAmount: string;
   transactionMode?: boolean;
   payOptions?: PayUIOptions;
+  onSuccess: ((status: BuyWithCryptoStatus) => void) | undefined;
 };
 
 export function TransferConfirmationScreen(
@@ -202,10 +209,33 @@ export function TransferConfirmationScreen(
                       to: receiverAddress,
                       amount: tokenAmount,
                     });
-                await sendAndConfirmTransaction({
-                  account: props.payer.account,
-                  transaction,
-                });
+                const [txResult, tokenMetadata] = await Promise.all([
+                  sendAndConfirmTransaction({
+                    account: props.payer.account,
+                    transaction,
+                  }),
+                  getCurrencyMetadata({
+                    contract: getContract({
+                      address: isNativeToken(token)
+                        ? NATIVE_TOKEN_ADDRESS
+                        : token.address,
+                      chain: chain,
+                      client: client,
+                    }),
+                  }),
+                ]);
+                // its the last step before the transaction, so propagate onPurchaseSuccess here
+                props.onSuccess?.(
+                  transferBuyWithCryptoQuote({
+                    token,
+                    chain,
+                    tokenMetadata,
+                    tokenAmount,
+                    fromAddress: payer.account.address,
+                    toAddress: receiverAddress,
+                    transaction: txResult,
+                  }),
+                );
                 // switch to execute step
                 setStep("execute");
                 setStatus({ id: "idle" });
@@ -299,3 +329,85 @@ export function TransferConfirmationScreen(
     </Container>
   );
 }
+
+function transferBuyWithCryptoQuote(args: {
+  token: ERC20OrNativeToken;
+  chain: Chain;
+  tokenMetadata: GetCurrencyMetadataResult;
+  tokenAmount: string;
+  fromAddress: string;
+  toAddress: string;
+  transaction: TransactionReceipt;
+}): BuyWithCryptoStatus {
+  const {
+    token,
+    chain,
+    tokenMetadata,
+    tokenAmount,
+    fromAddress,
+    toAddress,
+    transaction,
+  } = args;
+  return {
+    status: "COMPLETED",
+    subStatus: "SUCCESS",
+    swapType: "TRANSFER",
+    quote: {
+      createdAt: new Date().toISOString(),
+      fromToken: {
+        chainId: chain.id,
+        tokenAddress: isNativeToken(token)
+          ? NATIVE_TOKEN_ADDRESS
+          : token.address,
+        decimals: tokenMetadata.decimals,
+        symbol: tokenMetadata.symbol,
+        name: tokenMetadata.name,
+        priceUSDCents: 0,
+      },
+      toToken: {
+        chainId: chain.id,
+        tokenAddress: isNativeToken(token)
+          ? NATIVE_TOKEN_ADDRESS
+          : token.address,
+        decimals: tokenMetadata.decimals,
+        symbol: tokenMetadata.symbol,
+        name: tokenMetadata.name,
+        priceUSDCents: 0,
+      },
+      fromAmountWei: toWei(tokenAmount).toString(),
+      fromAmount: tokenAmount,
+      toAmountWei: toWei(tokenAmount).toString(),
+      toAmount: tokenAmount,
+      toAmountMin: tokenAmount,
+      toAmountMinWei: toWei(tokenAmount).toString(),
+      estimated: {
+        feesUSDCents: 0,
+        gasCostUSDCents: 0,
+        slippageBPS: 0,
+        toAmountMinUSDCents: 0,
+        toAmountUSDCents: 0,
+        fromAmountUSDCents: 0,
+        durationSeconds: 0,
+      },
+    },
+    fromAddress,
+    toAddress,
+    source: {
+      transactionHash: transaction.transactionHash,
+      amount: tokenAmount,
+      amountWei: toWei(tokenAmount).toString(),
+      amountUSDCents: 0,
+      completedAt: new Date().toISOString(),
+      token: {
+        chainId: chain.id,
+        tokenAddress: isNativeToken(token)
+          ? NATIVE_TOKEN_ADDRESS
+          : token.address,
+        decimals: tokenMetadata.decimals,
+        symbol: tokenMetadata.symbol,
+        name: tokenMetadata.name,
+        priceUSDCents: 0,
+      },
+    },
+  };
+}

packages/thirdweb/src/wallets/smart/lib/bundler.ts

@@ -179,6 +179,7 @@ export async function estimateUserOpGasCost(args: {
         client: args.client,
       }),
     ),
+    waitForDeployment: false,
   });
 
   let gasLimit = 0n;

packages/thirdweb/src/wallets/smart/lib/userop.ts

@@ -321,7 +321,9 @@ async function populateUserOp_v0_7(args: {
         createAccountOverride: overrides?.createAccount,
       }),
     );
-    markAccountDeploying(accountContract);
+    if (waitForDeployment) {
+      markAccountDeploying(accountContract);
+    }
   }
 
   const partialOp: UserOperationV07 = {
@@ -481,7 +483,9 @@ async function populateUserOp_v0_6(args: {
       accountSalt: overrides?.accountSalt,
       createAccountOverride: overrides?.createAccount,
     });
-    markAccountDeploying(accountContract);
+    if (waitForDeployment) {
+      markAccountDeploying(accountContract);
+    }
   }
 
   const partialOp: UserOperationV06 = {

packages/thirdweb/src/wallets/smart/smart-wallet-integration-v07.test.ts

@@ -52,6 +52,7 @@ const contract = getContract({
 describe.runIf(process.env.TW_SECRET_KEY).sequential(
   "SmartWallet 0.7 core tests",
   {
+    retry: 0,
     timeout: 240_000,
   },
   () => {

packages/thirdweb/src/wallets/smart/smart-wallet-integration.test.ts

@@ -52,6 +52,7 @@ const factoryAddress = "0x564cf6453a1b0FF8DB603E92EA4BbD410dea45F3"; // pre 712
 describe.runIf(process.env.TW_SECRET_KEY).sequential(
   "SmartWallet core tests",
   {
+    retry: 0,
     timeout: 240_000,
   },
   () => {