Skip to content

feat: switch to v2 bundler for all user operations #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat: switch to v2 bundler for all user operations #4884

merged 1 commit into from
Oct 2, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 2, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on switching to the v2 bundler for improved performance across user operations in the thirdweb package.

Detailed summary

  • Updated getDefaultBundlerUrl to use v2 directly, removing version parameter.
  • Simplified bundler URL logic in userop.ts, paymaster.ts, and bundler.ts.
  • Removed conditional logic for determining bundler and paymaster versions based on entry point version.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:33am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:33am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:33am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:33am

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 5d62ddf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 2, 2024 07:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.98 KB (0%) 840 ms (0%) 186 ms (+12% 🔺) 1.1 s
thirdweb (cjs) 101.58 KB (0%) 2.1 s (0%) 532 ms (+15.17% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 36 ms (+87.23% 🔺) 133 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 14 ms (+336.91% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 16.74 KB (-0.07% 🔽) 335 ms (-0.07% 🔽) 48 ms (+82.35% 🔺) 383 ms

@codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (454f063) to head (5d62ddf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/thirdweb/src/wallets/smart/lib/constants.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4884      +/-   ##
==========================================
- Coverage   47.60%   47.49%   -0.11%     
==========================================
  Files        1054     1055       +1     
  Lines       57164    57190      +26     
  Branches     3917     3902      -15     
==========================================
- Hits        27212    27164      -48     
- Misses      29263    29337      +74     
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 454f063
packages 43.22% <83.33%> (-0.13%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/lib/bundler.ts 45.78% <100.00%> (-13.87%) ⬇️
...ckages/thirdweb/src/wallets/smart/lib/paymaster.ts 59.15% <100.00%> (-9.34%) ⬇️
packages/thirdweb/src/wallets/smart/lib/userop.ts 67.12% <100.00%> (-3.40%) ⬇️
...ckages/thirdweb/src/wallets/smart/lib/constants.ts 85.36% <66.66%> (+2.43%) ⬆️

... and 2 files with indirect coverage changes

jnsdls
jnsdls reviewed Oct 2, 2024
View reviewed changes
packages/thirdweb/src/wallets/smart/lib/paymaster.ts
const entrypointVersion = getEntryPointVersion(entrypoint);
const paymasterVersion = entrypointVersion === "v0.6" ? "v1" : "v2";
const paymasterUrl = getDefaultBundlerUrl(chain, paymasterVersion);
const paymasterUrl = getDefaultBundlerUrl(chain);
Copy link
Member

@jnsdls jnsdls Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was no reason why we would need to point at /v1? /v2 handles everything /v1 did?

Copy link
Member Author

@joaquim-verges joaquim-verges Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it does

@joaquim-verges joaquim-verges merged commit e548675 into main Oct 2, 2024
28 checks passed
@joaquim-verges joaquim-verges deleted the feat_switch_to_v2_bundler_for_all_user_operations branch October 2, 2024 21:12
@jnsdls jnsdls mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls left review comments

@0xFirekeeper 0xFirekeeper Awaiting requested review from 0xFirekeeper

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls