From 985c4b08048c3676dc9be0c2069fefc73a742a3a Mon Sep 17 00:00:00 2001 From: ElasticBottle Date: Wed, 2 Oct 2024 22:38:54 +0000 Subject: [PATCH] fix: add missing partner id for ecosystem wallet (#4886) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Problem solved Short description of the bug fixed or feature added --- ## PR-Codex overview This PR focuses on fixing the issue of missing `partnerId` when creating an ecosystem wallet in the `thirdweb` package. ### Detailed summary - Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/web/ecosystem.ts` to use `ecosystem.partnerId`. - Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/native/ecosystem.ts` to use `createOptions?.partnerId`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- .changeset/famous-spies-grab.md | 5 +++++ packages/thirdweb/src/wallets/in-app/native/ecosystem.ts | 1 + packages/thirdweb/src/wallets/in-app/web/ecosystem.ts | 1 + 3 files changed, 7 insertions(+) create mode 100644 .changeset/famous-spies-grab.md diff --git a/.changeset/famous-spies-grab.md b/.changeset/famous-spies-grab.md new file mode 100644 index 00000000000..e647f578018 --- /dev/null +++ b/.changeset/famous-spies-grab.md @@ -0,0 +1,5 @@ +--- +"thirdweb": patch +--- + +fix missing partner id when creating ecosystem wallet diff --git a/packages/thirdweb/src/wallets/in-app/native/ecosystem.ts b/packages/thirdweb/src/wallets/in-app/native/ecosystem.ts index 836d4eba141..ee7948619e0 100644 --- a/packages/thirdweb/src/wallets/in-app/native/ecosystem.ts +++ b/packages/thirdweb/src/wallets/in-app/native/ecosystem.ts @@ -76,6 +76,7 @@ export function ecosystemWallet( ...createOptions?.auth, options: [], // controlled by ecosystem }, + partnerId: createOptions?.partnerId, }, connectorFactory: async (client: ThirdwebClient) => { const { InAppNativeConnector } = await import("./native-connector.js"); diff --git a/packages/thirdweb/src/wallets/in-app/web/ecosystem.ts b/packages/thirdweb/src/wallets/in-app/web/ecosystem.ts index 8bbfda79d77..12cb4e7552f 100644 --- a/packages/thirdweb/src/wallets/in-app/web/ecosystem.ts +++ b/packages/thirdweb/src/wallets/in-app/web/ecosystem.ts @@ -76,6 +76,7 @@ export function ecosystemWallet( ...createOptions?.auth, options: [], // controlled by ecosystem }, + partnerId: ecosystem.partnerId, }, connectorFactory: async (client: ThirdwebClient) => { const { InAppWebConnector } = await import("./lib/web-connector.js");