Skip to content

temp - no need review #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

temp - no need review #4947

wants to merge 4 commits into from

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 7, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on improving the getBatchesToReveal function and refactoring the NFTRevealButton component to enhance error handling and user experience during NFT batch revealing processes.

Detailed summary

  • Added error handling to getBatchesToReveal to return undefined for failed metadata.
  • Updated the mapping of tokenMetadatas to filter out undefined values.
  • Refactored NFTRevealButton to remove MinterOnly wrapper.
  • Cleaned up the form submission logic in NFTRevealButton.
  • Improved user feedback with toast notifications during transaction processing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kien-ngo kien-ngo self-assigned this Oct 7, 2024
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f7753d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 2:17am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 16, 2024 2:17am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 16, 2024 2:17am
wallet-ui ⬜️ Skipped (Inspect) Oct 16, 2024 2:17am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 3 s (+10.17% 🔺) 3.9 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 7 s (+16.94% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 403 ms (+62.31% 🔺) 500 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 82 ms (-27.83% 🔽) 92 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 756 ms (+44.6% 🔺) 1.2 s

@kien-ngo kien-ngo closed this Oct 8, 2024
@kien-ngo kien-ngo deleted the kien/temp-fix-reveal-button branch October 15, 2024 06:01
@kien-ngo kien-ngo restored the kien/temp-fix-reveal-button branch October 16, 2024 01:38
@kien-ngo kien-ngo reopened this Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (3a141e7) to head (9f7753d).

Files with missing lines Patch % Lines
...ions/erc721/lazyMinting/read/getBatchesToReveal.ts 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4947   +/-   ##
=======================================
  Coverage   45.29%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54724    54730    +6     
  Branches     3953     3957    +4     
=======================================
+ Hits        24786    24794    +8     
+ Misses      29247    29245    -2     
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d6c2414
packages 40.24% <69.23%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ions/erc721/lazyMinting/read/getBatchesToReveal.ts 78.88% <69.23%> (-2.07%) ⬇️

... and 2 files with indirect coverage changes

@kien-ngo kien-ngo requested a review from MananTank as a code owner October 16, 2024 02:08
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 02:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 02:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 02:08 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2024
@kien-ngo kien-ngo changed the title temp temp - no need review Oct 16, 2024
@kien-ngo kien-ngo closed this Oct 16, 2024
@kien-ngo kien-ngo deleted the kien/temp-fix-reveal-button branch October 16, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

@kien-ngo kien-ngo

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kien-ngo