Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the TeamMembersSettingsPage and related components by introducing alerts for unavailable features, refining member management logic, and improving filtering and sorting capabilities for team members.

Detailed summary

  • Added an Alert to TeamMembersSettingsPage indicating feature unavailability.
  • Modified inviteEnabled logic in InviteSection to exclude the "free" plan.
  • Updated error handling in getMembers to return undefined instead of an empty array.
  • Enhanced Page component to check for account and members.
  • Adjusted ManageMembersSection to filter and sort members based on selected role.
  • Changed member stubs to use a teamStub function for consistency.
  • Improved UI labels and messages for better clarity.
  • Refactored filtering logic in ManageMembersSection to use useMemo for performance.
  • Added props for role and sort management in FiltersSection and RoleSelector.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: bd0dbb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 21:53 Inactive
@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 9, 2024 10:56pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 9, 2024 10:56pm
wallet-ui ⬜️ Skipped (Inspect) Oct 9, 2024 10:56pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 21:53 Inactive
@MananTank MananTank marked this pull request as ready for review October 9, 2024 21:53
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 9, 2024
Copy link
Member Author

MananTank commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank force-pushed the 10-10-team_member_settings_page_updates branch from 7123716 to 80c8ecb Compare October 9, 2024 21:54
@MananTank MananTank changed the base branch from kien/fix-minor-ui-oct-5 to main October 9, 2024 21:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 21:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 21:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 21:54 Inactive
@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (f5b8230) to head (bd0dbb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage   47.68%   47.68%           
=======================================
  Files        1058     1058           
  Lines       57290    57290           
  Branches     3942     3942           
=======================================
  Hits        27319    27319           
  Misses      29280    29280           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f5b8230
packages 43.46% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 2 s (+9.46% 🔺) 2.9 s
thirdweb (cjs) 101.66 KB (0%) 2.1 s (0%) 4.9 s (+22.76% 🔺) 7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 109 ms (+0.51% 🔺) 206 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 46 ms (+77.13% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 350 ms (-26.54% 🔽) 695 ms

@MananTank MananTank force-pushed the 10-10-team_member_settings_page_updates branch from 80c8ecb to d329326 Compare October 9, 2024 22:02
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 22:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 22:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 22:02 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `TeamMembersSettingsPage` by adding an alert for unavailable features, updating the logic for invite permissions, and refining member management with improved filtering and sorting functionalities.

### Detailed summary
- Added an `Alert` component in `TeamMembersSettingsPage` to notify users about feature availability.
- Changed the condition for `inviteEnabled` in `InviteSection` to check for non-free plans.
- Updated member management logic to filter and sort members based on roles.
- Modified the `ManageMembersSection` to use filtered member lists for display and actions.
- Adjusted the `createMemberStub` function to accept a `createdHours` parameter.
- Updated storybook examples to reflect changes in team plans and permissions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-10-team_member_settings_page_updates branch from d329326 to bd0dbb7 Compare October 9, 2024 22:46
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2024 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2024 22:46 Inactive
@graphite-app graphite-app bot merged commit bd0dbb7 into main Oct 9, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-10-team_member_settings_page_updates branch October 9, 2024 22:56
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 9, 2024 22:56 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 9, 2024 22:56 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 9, 2024 22:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants