-
Notifications
You must be signed in to change notification settings - Fork 619
Team Member Settings Page updates #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
7123716 to
80c8ecb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4978 +/- ##
=======================================
Coverage 47.68% 47.68%
=======================================
Files 1058 1058
Lines 57290 57290
Branches 3942 3942
=======================================
Hits 27319 27319
Misses 29280 29280
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
80c8ecb to
d329326
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `TeamMembersSettingsPage` by adding an alert for unavailable features, updating the logic for invite permissions, and refining member management with improved filtering and sorting functionalities.
### Detailed summary
- Added an `Alert` component in `TeamMembersSettingsPage` to notify users about feature availability.
- Changed the condition for `inviteEnabled` in `InviteSection` to check for non-free plans.
- Updated member management logic to filter and sort members based on roles.
- Modified the `ManageMembersSection` to use filtered member lists for display and actions.
- Adjusted the `createMemberStub` function to accept a `createdHours` parameter.
- Updated storybook examples to reflect changes in team plans and permissions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
d329326 to
bd0dbb7
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
TeamMembersSettingsPageand related components by introducing alerts for unavailable features, refining member management logic, and improving filtering and sorting capabilities for team members.Detailed summary
AlerttoTeamMembersSettingsPageindicating feature unavailability.inviteEnabledlogic inInviteSectionto exclude the "free" plan.getMembersto returnundefinedinstead of an empty array.Pagecomponent to check foraccountandmembers.ManageMembersSectionto filter and sort members based on selected role.teamStubfunction for consistency.ManageMembersSectionto useuseMemofor performance.FiltersSectionandRoleSelector.