Add Date Range and Interval Selector on Connect Analytics page #4988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
=======================================
Coverage 47.74% 47.74%
=======================================
Files 1059 1059
Lines 57328 57328
Branches 3944 3944
=======================================
Hits 27369 27369
Misses 29268 29268
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
jnsdls
reviewed
Oct 10, 2024
...oard/src/app/team/[team_slug]/[project_slug]/connect/analytics/ConnectAnalyticsDashboard.tsx
Outdated
Show resolved
Hide resolved
...oard/src/app/team/[team_slug]/[project_slug]/connect/analytics/ConnectAnalyticsDashboard.tsx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
10-10-add_date_range_selector_for_connect_analaytics
branch
from
0fd4f70 to
ebeb42f
Compare
MananTank
force-pushed
the
10-10-add_date_range_selector_for_connect_analaytics
branch
from
ebeb42f to
ef393ad
Compare
MananTank
changed the title
jnsdls
approved these changes
Oct 10, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the date range selection functionality in the `PayAnalytics` and `ConnectAnalyticsDashboard` components by incorporating the `subDays` function and restructuring the date range handling.
### Detailed summary
- Added `subDays` import from `date-fns` for date calculations.
- Refactored `getLastNDaysRange` to use `subDays` for calculating past dates.
- Moved and restructured the `presets` rendering logic in `Filters` for clarity.
- Introduced `DateRangeSelector` and `IntervalSelector` components in `ConnectAnalyticsDashboard`.
- Replaced `useMemo` with `useState` for managing date ranges in `ConnectAnalyticsDashboard`.
- Simplified date range handling and interval type selection.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
MananTank
force-pushed
the
10-10-add_date_range_selector_for_connect_analaytics
branch
from
ef393ad to
d7e34f2
Compare
graphite-app
bot
deleted the
10-10-add_date_range_selector_for_connect_analaytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
PayAnalyticsandConnectAnalyticsDashboardcomponents by improving date handling and adding new date range selection features.Detailed summary
subDaysimport fromdate-fnsfor date calculations.getLastNDaysRangeto usesubDaysfor calculating past dates.Filterscomponent to include a header with aSelectfor date presets.DateRangeSelectorandIntervalSelectorcomponents inConnectAnalyticsDashboard.ConnectAnalyticsDashboard.