Chore: deprecate iframe #4991
Chore: deprecate iframe #4991
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4991 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 1058 1058
Lines 57290 57290
Branches 3945 3943 -2
=======================================
Hits 27364 27364
Misses 29235 29235
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
gregfromstl
added
the
merge-queue
Merge activity
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on deprecating two authentication strategies in the `types.ts` file related to in-app wallets. The strategies for `iframe_email_verification` and `iframe` are marked as deprecated, which indicates they should not be used in future implementations.
### Detailed summary
- Added `@deprecated` comment to the `iframe_email_verification` strategy.
- Added `@deprecated` comment to the `iframe` strategy.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
chore/deprecate-iframe
branch
from
09c1297 to
2914a50
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on deprecating the
iframe_email_verificationandiframestrategies in thetypes.tsfile related to authentication methods in thethirdwebwallet package.Detailed summary
@deprecatedcomments to theiframe_email_verificationstrategy, indicating it is no longer recommended for use.@deprecatedcomments to theiframestrategy, indicating it is no longer recommended for use.