Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 11, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring and updating components in the dashboard application, including changes to imports, link handling, and component structure for improved functionality and user experience.

Detailed summary

  • Removed Dashboard and DashboardSettingsStorage constants.
  • Updated Link import in Changelog.tsx from tw-components to next/link.
  • Changed isExternal prop to target="_blank" in Changelog.tsx.
  • Adjusted Skeleton width in Changelog.tsx.
  • Added a new Page function in page.tsx to fetch and display changelog and onboarding steps.
  • Introduced getChangelog function to fetch latest changes from an API.
  • Updated HomeProductCard to use next/image and next/link.
  • Refactored OnboardingSteps to use a constant object for Step.
  • Changed LinkButton to a Button with a Link child in OnboardingSteps.
  • Enhanced layout and styling across multiple components for better UI consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 96d4ad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm
wallet-ui ⬜️ Skipped (Inspect) Oct 14, 2024 9:28pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 11, 2024 20:30 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 11, 2024 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 11, 2024 20:30 Inactive
@MananTank MananTank marked this pull request as ready for review October 11, 2024 20:30
Copy link
Member Author

MananTank commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 11, 2024
@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (92fbb18) to head (96d4ad1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4996   +/-   ##
=======================================
  Coverage   47.77%   47.77%           
=======================================
  Files        1058     1058           
  Lines       57276    57276           
  Branches     3946     3946           
=======================================
  Hits        27362    27362           
  Misses      29223    29223           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 92fbb18
packages 43.57% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 470 ms (+55.97% 🔺) 1.4 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 1.2 s (+61.14% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 47 ms (+24.15% 🔺) 144 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 41 ms (+100.27% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 252 ms (+99.98% 🔺) 597 ms

@MananTank MananTank changed the title Move Dashboard landing page to App router Move Dashboard landing page to App router + Migrate to shadncn/tailwind Oct 11, 2024
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 2d4f96c to 50644a6 Compare October 14, 2024 17:54
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from 71dfbaf to 424cd26 Compare October 14, 2024 17:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 17:54 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 50644a6 to 77d7d50 Compare October 14, 2024 17:58
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from 424cd26 to aa9ea17 Compare October 14, 2024 17:59
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 17:59 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 77d7d50 to be1b851 Compare October 14, 2024 18:19
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from aa9ea17 to 22caeea Compare October 14, 2024 18:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 18:19 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from be1b851 to bcf1624 Compare October 14, 2024 19:13
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from 22caeea to d21756c Compare October 14, 2024 19:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 19:14 Inactive
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from bcf1624 to 4b31754 Compare October 14, 2024 20:15
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from d21756c to 1f6b14a Compare October 14, 2024 20:15
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 20:15 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2024

Merge activity

…nd (#4996)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring components in the `dashboard` section of the application, updating imports, and improving the layout and functionality of the `Changelog`, `HomeProductCard`, and `OnboardingSteps` components.

### Detailed summary
- Removed obsolete `Dashboard` constants.
- Updated `Link` import in `Changelog` from `tw-components` to `next/link`.
- Adjusted `Changelog` component to include a wider `Skeleton`.
- Modified `HomeProductCard` to use `next/image` and `next/link`.
- Enhanced `OnboardingSteps` to use a new structure for steps and modified the rendering logic.
- Changed step keys to a constant object format.
- Improved layout and styling for various components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-11-move_deployed_contracts_page_to_app_router branch from 4b31754 to 92fbb18 Compare October 14, 2024 20:53
@MananTank MananTank force-pushed the 10-12-move_dashboard_landing_page_to_app_router branch from 1f6b14a to 96d4ad1 Compare October 14, 2024 20:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 14, 2024 20:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 20:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 20:54 Inactive
Base automatically changed from 10-11-move_deployed_contracts_page_to_app_router to main October 14, 2024 21:28
@graphite-app graphite-app bot merged commit 96d4ad1 into main Oct 14, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 10-12-move_dashboard_landing_page_to_app_router branch October 14, 2024 21:29
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 14, 2024 21:29 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 14, 2024 21:29 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 14, 2024 21:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants