Skip to content

[SDK / Wallet UI] URI Connection #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2024
Merged

[SDK / Wallet UI] URI Connection #4997

merged 3 commits into from
Oct 13, 2024
+131 −87

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Oct 11, 2024 •
edited by pr-codex bot
Loading

wc.mp4

PR-Codex overview

This PR focuses on enhancing the wallet connection functionality within the application, particularly integrating WalletConnect, improving user redirection, and refactoring components for better structure and usability.

Detailed summary

  • Removed the page.tsx file from the wallet address directory.
  • Updated createWalletConnectSession to use a simpler call.
  • Introduced AutoConnectWalletConnect component for automatic wallet connection.
  • Improved user redirection logic in the login and wallet pages.
  • Refactored ConnectButton and ConnectEmbed components for better usability.
  • Added useWalletConnect hook to manage wallet connection state.
  • Adjusted layout and structure in wallet-related pages for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4872caf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:05pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:05pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:05pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:05pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@gregfromstl gregfromstl force-pushed the feat/wc-uri-connection branch from 1416a47 to aa0b151 Compare October 11, 2024 21:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 437 ms (+75.54% 🔺) 1.3 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 664 ms (-15.51% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 24 ms (-17.77% 🔽) 120 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 83 ms (+394.68% 🔺) 93 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 58 ms (-14.83% 🔽) 403 ms

joaquim-verges
joaquim-verges reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to cleanup the logs, otherwise looks good

@gregfromstl gregfromstl force-pushed the feat/wc-uri-connection branch from 2872f11 to 4872caf Compare October 13, 2024 16:47
@codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.01%. Comparing base (cd2c0f3) to head (4872caf).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4997      +/-   ##
==========================================
+ Coverage   47.72%   48.01%   +0.28%     
==========================================
  Files        1059     1057       -2     
  Lines       57323    56907     -416     
  Branches     3941     3947       +6     
==========================================
- Hits        27359    27323      -36     
+ Misses      29273    28893     -380     
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from cd2c0f3
packages 43.83% <100.00%> (+0.31%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...rdweb/src/wallets/wallet-connect/receiver/index.ts 86.50% <ø> (ø)
...wallets/wallet-connect/receiver/session-request.ts 87.93% <100.00%> (-0.90%) ⬇️

... and 5 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit db5457f into main Oct 13, 2024
30 checks passed
@joaquim-verges joaquim-verges deleted the feat/wc-uri-connection branch October 13, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregfromstl @joaquim-verges