Skip to content

feat: Engine delete modal now prompts to permanently delete, calls new route #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: Engine delete modal now prompts to permanently delete, calls new route #4998

merged 1 commit into from
Oct 15, 2024
+94 −76

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Oct 11, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on renaming and restructuring the functionality related to deleting cloud-hosted engines in the useEngine hook and the EngineInstancesTable component, enhancing clarity and user experience by changing terminology and improving the delete process.

Detailed summary

  • Renamed RemoveCloudHostedInput to DeleteCloudHostedInput and updated its properties.
  • Changed function name from useEngineRemoveCloudHosted to useEngineDeleteCloudHosted.
  • Updated API endpoint for deleting cloud-hosted engines.
  • Modified UI text from "Remove" to "Delete" for better clarity.
  • Enhanced confirmation dialog for deletion with clearer messaging.
  • Added feedback section in the deletion form.
  • Made deletion action irreversible with appropriate alerts and confirmations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8247448

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 4:49pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 4:49pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 4:49pm
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 4:49pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 11, 2024
@codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (958bedd) to head (8247448).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4998   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54707    54707           
  Branches     3954     3954           
=======================================
  Hits        24786    24786           
  Misses      29230    29230           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 958bedd
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 497 ms (+26.95% 🔺) 1.4 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 882 ms (+39.03% 🔺) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 95 ms (+74.96% 🔺) 191 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 91 ms (+392.59% 🔺) 101 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 88 ms (+20.25% 🔺) 435 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 06:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 06:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 06:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 06:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 06:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 06:38 Inactive
@arcoraven arcoraven enabled auto-merge (squash) October 15, 2024 06:42
@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 15, 2024
@arcoraven Graphite App
Copy link
Contributor Author

arcoraven commented Oct 15, 2024 •
edited
Loading

Merge activity

  • Oct 15, 12:36 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 15, 12:45 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 15, 12:49 PM EDT: A user merged this pull request with the Graphite merge queue.

@arcoraven
feat: Engine delete modal now prompts to permanently delete, calls ne…
8247448 
…w route (#4998)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on renaming and modifying the functionality related to deleting cloud-hosted engines in the `useEngine` hook and its usage in the `EngineInstancesTable`. The changes include updates to input types, function names, and UI elements for clarity and consistency.

### Detailed summary
- Renamed `RemoveCloudHostedInput` to `DeleteCloudHostedInput`.
- Changed `instanceId` to `deploymentId` in the input type.
- Renamed `useEngineRemoveCloudHosted` to `useEngineDeleteCloudHosted`.
- Updated API endpoint in the mutation function.
- Changed UI labels from "Remove" to "Delete" and "Cancel Engine Subscription" to "Permanently Delete Engine".
- Added feedback textarea in the delete confirmation modal.
- Enhanced alert messages for irreversible actions.
- Updated handling of deletion confirmation acknowledgment.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 16:46 Inactive
@graphite-app graphite-app bot merged commit 8247448 into main Oct 15, 2024
30 checks passed
@graphite-app graphite-app bot deleted the ph/selfServeCancel branch October 15, 2024 16:49
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 16:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arcoraven @MananTank