Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 12, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the documentation in packages/thirdweb/src/transaction/read-contract.ts to clarify the usage of raw contract calls and the resolveMethod helper, emphasizing type safety and providing clearer examples.

Detailed summary

  • Revised the explanation for reading state from a deployed smart contract.
  • Updated the section title from "Using a contract read extension" to "Raw contract call (recommended)".
  • Added a note on type safety for raw contract calls.
  • Introduced a new section for using resolveMethod, highlighting its limitations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024

⚠️ No Changeset found

Latest commit: fdce5e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 9:16am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 9:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 9:16am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 9:16am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 12, 2024 09:05
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 215 ms (+48.01% 🔺) 1.1 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 403 ms (+39.36% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 6 ms (-44.51% 🔽) 103 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 27 ms (+506.6% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 71 ms (+125.97% 🔺) 416 ms

@joaquim-verges joaquim-verges merged commit 4f346e6 into main Oct 12, 2024
25 of 28 checks passed
@joaquim-verges joaquim-verges deleted the docs_update_read-contract_usage_examples_and_explanations branch October 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants