[SDK] Fix upload reveal batch #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6faf63f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
added
the
hotfix
Contributor
Author
Merge activity
|
Contributor
size-limit report 📦
|
gregfromstl
approved these changes
Oct 14, 2024
jnsdls
requested changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5009 +/- ##
==========================================
+ Coverage 45.27% 45.28% +0.01%
==========================================
Files 1058 1058
Lines 54660 54670 +10
Branches 3947 3950 +3
==========================================
+ Hits 24747 24757 +10
Misses 29222 29222
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
commented
Oct 14, 2024
packages/thirdweb/src/extensions/erc721/lazyMinting/write/createDelayedRevealBatch.test.ts
Outdated
Show resolved
Hide resolved
jnsdls
requested changes
Oct 14, 2024
packages/thirdweb/src/extensions/erc721/lazyMinting/write/createDelayedRevealBatch.test.ts
Outdated
Show resolved
Hide resolved
jnsdls
approved these changes
Oct 15, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing the upload logic for creating delayed reveal batches in the `thirdweb` package. It improves the handling of file uploads and the calculation of starting file numbers for batches, ensuring proper functionality during NFT batch creation and reveal.
### Detailed summary
- Updated `createDelayedRevealBatch` to use `Promise.all` for concurrent uploads and token ID retrieval.
- Added logic to calculate the starting file number for batch uploads.
- Removed mock implementations for certain functions in the test file.
- Enhanced test cases to verify proper creation and revealing of NFT batches.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/fix-reveal-batch
branch
from
ed2adba to
6faf63f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing the upload logic in the
createDelayedRevealBatchfunction for handling delayed reveal batches in thethirdweblibrary. It enhances the functionality by ensuring proper file naming and integrates the retrieval of the next token ID.Detailed summary
createDelayedRevealBatchto usePromise.allfor concurrent uploads and token ID retrieval.startFileNumberto correctly calculate file names for batch uploads.