[SDK] ERC1155 extension: mintAdditionalSupplyToBatch #5036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f8c981c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
23a8911 to
20566fb
Compare
Contributor
size-limit report 📦
|
jnsdls
requested changes
Oct 15, 2024
packages/thirdweb/src/extensions/erc1155/write/mintAdditionalSupplyToBatch.ts
Outdated
Show resolved
Hide resolved
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
20566fb to
34be284
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5036 +/- ##
==========================================
+ Coverage 45.30% 45.33% +0.02%
==========================================
Files 1059 1060 +1
Lines 54754 54773 +19
Branches 3958 3954 -4
==========================================
+ Hits 24809 24832 +23
+ Misses 29254 29250 -4
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
previously requested changes
Oct 17, 2024
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
34be284 to
8607705
Compare
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
8607705 to
cb4a302
Compare
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
cb4a302 to
c202eb6
Compare
joaquim-verges
approved these changes
Oct 20, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new ERC1155 extension called `mintAdditionalSupplyToBatch`, allowing users to mint additional supplies of NFTs in a single transaction. It also modifies existing minting logic for better handling of asynchronous operations.
### Detailed summary
- Added new extension `mintAdditionalSupplyToBatch` in `mintAdditionalSupplyToBatch.ts`.
- Updated `mintToBatch.ts` for improved async handling and data processing.
- Created tests for `mintAdditionalSupplyToBatch` in `mintAdditionalSupplyToBatch.test.ts`.
- Updated export statements in `erc1155.ts` to include the new function.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/erc1155-mintAdditionalSupplyToBatch
branch
from
c202eb6 to
f8c981c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a new ERC1155 extension called
mintAdditionalSupplyToBatch, enabling the minting of additional supplies for multiple NFTs in a single transaction. It enhances the functionality of thethirdweblibrary for efficient NFT management.Detailed summary
mintAdditionalSupplyToBatch.mintAdditionalSupplyToBatchand its parameters fromerc1155.ts.mintToBatch.tsfor better async handling and error management.mintAdditionalSupplyToBatchto validate its functionality.