Skip to content

Migrate Marketplace listing cards on overview page to shadcn/tailwind #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Migrate Marketplace listing cards on overview page to shadcn/tailwind #5041

merged 1 commit into from
Oct 15, 2024
+102 −90

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 15, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR primarily focuses on updating the styling of the NFT media components and refactoring the MarketplaceDetails component to improve the code structure and enhance the UI elements.

Detailed summary

  • Changed rounded-xl to rounded-lg in nft-media.tsx for improved styling.
  • Replaced TrackedLink with TrackedLinkTW in MarketplaceDetails.tsx for consistency.
  • Removed unused imports from MarketplaceDetails.tsx.
  • Adjusted the rendering logic for skeleton loaders and links in the listing cards.
  • Updated layout from SimpleGrid to a custom grid structure for better responsiveness.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e701fbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 9:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 9:47pm
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 9:47pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 15, 2024 21:35
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (ccff347) to head (e701fbf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5041   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54707    54707           
  Branches     3954     3954           
=======================================
  Hits        24786    24786           
  Misses      29230    29230           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ccff347
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 1.6 s (+15.4% 🔺) 2.4 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 3.4 s (+8.77% 🔺) 5.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 205 ms (+26.21% 🔺) 302 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 54 ms (+89.39% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 483 ms (+111.49% 🔺) 830 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024 •
edited by jnsdls
Loading

Merge activity

@MananTank
Migrate Marketplace listing cards on overview page to shadcn/tailwind (…
e701fbf 
…#5041)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating the styling and structure of components in the `MarketplaceDetails` and `ListingCards` sections, replacing certain components with new ones and enhancing the layout.

### Detailed summary
- Changed `rounded-xl` to `rounded-lg` in `nft-media.tsx`.
- Replaced `TrackedLink` with `TrackedLinkTW` in `MarketplaceDetails.tsx`.
- Removed unused imports from `MarketplaceDetails.tsx`.
- Updated layout in `ListingCards` with a new grid structure.
- Enhanced `Skeleton` components with `SkeletonContainer` for better loading states.
- Improved styling and structure of listing items.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-16-migrate_marketplace_listing_cards_on_overview_page_to_shadcn_tailwind branch from 992cdba to e701fbf Compare October 15, 2024 21:45
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 21:45 Inactive
@graphite-app graphite-app bot merged commit e701fbf into main Oct 15, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-16-migrate_marketplace_listing_cards_on_overview_page_to_shadcn_tailwind branch October 15, 2024 21:48
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 21:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls