Move /accounts contract page in app router folder (no code change) #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
jnsdls
approved these changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5044 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1059 1059
Lines 54714 54714
Branches 3953 3953
=======================================
Hits 24787 24787
Misses 29236 29236
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
10-16-move_account-permissions_page_components_in_app_router_folder_no_code_change_
branch
from
396db14 to
cee0a0c
Compare
MananTank
force-pushed
the
10-16-move__accounts_contract_page_in_app_router_folder_no_code_change_
branch
from
7ba8e19 to
257f10b
Compare
jnsdls
force-pushed
the
10-16-move_account-permissions_page_components_in_app_router_folder_no_code_change_
branch
from
cee0a0c to
eaf303b
Compare
Contributor
Merge activity
|
Base automatically changed from
10-16-move_account-permissions_page_components_in_app_router_folder_no_code_change_
to
main
October 15, 2024 22:16
…5044) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the structure of account-related components in the dashboard, improving import paths for better clarity and maintainability. ### Detailed summary - Updated the import path for `AccountsPage` in `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/accounts/page.tsx`. - Removed an unnecessary import of `useChainSlug` in `accounts-table.tsx` and replaced it with a direct import. - Added `useChainSlug` import in `accounts-table.tsx` from a new path. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
10-16-move__accounts_contract_page_in_app_router_folder_no_code_change_
branch
from
257f10b to
0159983
Compare
graphite-app
bot
deleted the
10-16-move__accounts_contract_page_in_app_router_folder_no_code_change_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the import statements and updating the structure of the
AccountsPageand related components to improve organization and maintainability.Detailed summary
AccountsPageinapps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/accounts/page.tsx.useChainSluginaccounts-table.tsxand replaced it with a direct import.useChainSluginapps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/accounts/components/accounts-table.tsx.