fix: improve wallet linking for ecosystems #5045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ec10e81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
joaquim-verges
requested review from
MananTank,
edwardysun,
gregfromstl and
jnsdls
as code owners
gregfromstl
approved these changes
Oct 15, 2024
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5045 +/- ##
==========================================
- Coverage 45.30% 45.30% -0.01%
==========================================
Files 1059 1059
Lines 54707 54714 +7
Branches 3954 3953 -1
==========================================
+ Hits 24786 24787 +1
- Misses 29230 29236 +6
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing wallet connection functionality by integrating ecosystem wallet support across various components in the `thirdweb` package.
### Detailed summary
- Updated `ConnectWalletSocialOptions.tsx` to include `ecosystem` in wallet connection.
- Modified `PassKeyLogin.tsx` to add `ecosystem` handling during signup.
- Enhanced `WalletAuth.tsx` to support ecosystem wallets.
- Improved `SocialLogin.tsx` by incorporating `ecosystem` in login methods.
- Adjusted `OTPLoginUI.tsx` to manage `ecosystem` data during authentication processes.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
fix_improve_wallet_linking_for_ecosystems
branch
from
09cf826 to
ec10e81
Compare
graphite-app
bot
deleted the
fix_improve_wallet_linking_for_ecosystems
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing wallet connection functionality by incorporating ecosystem information into various wallet-related components, improving user experience during wallet interactions.
Detailed summary
ConnectWalletSocialOptions.tsxto includeecosysteminformation.PassKeyLogin.tsxto passecosystemduring signup.WalletAuth.tsxto includeecosystemin the linking process.SocialLogin.tsxto utilizeecosystemfor authentication.OTPLoginUI.tsxto integrateecosystemin pre-authentication and connection processes.