Skip to content

[Dashboard] Fix prepareEvent code snippet #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

[Dashboard] Fix prepareEvent code snippet #5052

merged 1 commit into from
Oct 17, 2024

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 16, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on removing redundant lines of code related to the preparedEvent variable in the code-overview.tsx file, streamlining the component without changing its functionality.

Detailed summary

  • Removed duplicate declarations of the preparedEvent variable in code-overview.tsx.
  • The preparedEvent now only appears once in the relevant scope, improving code clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 11:32am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 17, 2024 11:32am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 17, 2024 11:32am
wallet-ui ⬜️ Skipped (Inspect) Oct 17, 2024 11:32am

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 05:15 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f8f90fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 05:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 05:15 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 16, 2024 05:15
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2024
@kien-ngo Graphite App
Copy link
Contributor Author

kien-ngo commented Oct 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (63037f1) to head (f8f90fd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5052   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 63037f1
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 1.6 s (+63.22% 🔺) 2.4 s
thirdweb (cjs) 102.53 KB (0%) 2.1 s (0%) 3 s (+5.44% 🔺) 5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 99 ms (+33.5% 🔺) 196 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 75 ms (+252.14% 🔺) 85 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 462 ms (+140.28% 🔺) 809 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 17, 2024 •
edited by MananTank
Loading

Merge activity

@kien-ngo
[Dashboard] Fix prepareEvent code snippet (#5052)
f8f90fd 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on removing redundant lines of code related to the `preparedEvent` declaration in the `code-overview.tsx` file.

### Detailed summary
- Removed duplicate declarations of `preparedEvent` that included `contract` and `signature: "{{function}}"`.
- Streamlined the `getContractEvents` function call by eliminating unnecessary lines.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-16-_dashboard_fix_prepareevent_code_snippet branch from 8b70b52 to f8f90fd Compare October 17, 2024 11:22
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 11:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 11:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 11:22 Inactive
@graphite-app graphite-app bot merged commit f8f90fd into main Oct 17, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-16-_dashboard_fix_prepareevent_code_snippet branch October 17, 2024 11:32
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 11:32 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 11:32 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 17, 2024 11:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kien-ngo @MananTank