Skip to content

feat: support smart account options for ecosystem wallets #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: support smart account options for ecosystem wallets #5091

merged 1 commit into from
Oct 22, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 21, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces support for smart account options in ecosystem wallets within the thirdweb package, enhancing wallet functionality and options for users.

Detailed summary

  • Added ecosystem parameter to createInAppWallet function.
  • Created EcosystemOptions type with smartAccountOptions.
  • Renamed getEcosystemWalletAuthOptions to getEcosystemOptions.
  • Updated ConnectWalletSocialOptions to use new getEcosystemOptions.
  • Integrated smart account logic in connectInAppWallet and autoConnectInAppWallet functions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:41am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:41am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:41am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:41am

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c2dee9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 21, 2024 09:19
@joaquim-verges joaquim-verges force-pushed the feat_support_smart_account_options_for_ecosystem_wallets branch from 7aa31dd to c2dee9f Compare October 21, 2024 09:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 632 ms (+66.92% 🔺) 1.5 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 681 ms (-0.25% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 230 ms (+1637.17% 🔺) 326 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 38 ms (+519.02% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 120 ms (+237.87% 🔺) 468 ms

@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (df128bf) to head (c2dee9f).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...s/thirdweb/src/wallets/in-app/core/wallet/index.ts 0.00% 54 Missing ⚠️
...ets/ecosystem/get-ecosystem-wallet-auth-options.ts 0.00% 3 Missing ⚠️
...dweb/src/wallets/in-app/core/wallet/in-app-core.ts 0.00% 3 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5091      +/-   ##
==========================================
- Coverage   45.29%   45.24%   -0.05%     
==========================================
  Files        1059     1059              
  Lines       54729    54787      +58     
  Branches     3956     3956              
==========================================
+ Hits        24789    24791       +2     
- Misses      29249    29305      +56     
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from df128bf
packages 40.18% <0.00%> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 7.16% <0.00%> (-0.02%) ⬇️
...ets/ecosystem/get-ecosystem-wallet-auth-options.ts 4.76% <0.00%> (ø)
...dweb/src/wallets/in-app/core/wallet/in-app-core.ts 17.88% <0.00%> (-0.45%) ⬇️
...s/thirdweb/src/wallets/in-app/core/wallet/index.ts 4.05% <0.00%> (-2.33%) ⬇️

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 45fcfb1 into main Oct 22, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_support_smart_account_options_for_ecosystem_wallets branch October 22, 2024 09:25
@jnsdls jnsdls mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@MananTank MananTank Awaiting requested review from MananTank

@jnsdls jnsdls Awaiting requested review from jnsdls

@edwardysun edwardysun Awaiting requested review from edwardysun

Assignees

No one assigned

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges