Skip to content

Fix all resolveScheme unhandled errors #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix all resolveScheme unhandled errors #5096

merged 1 commit into from
Oct 21, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 21, 2024 •
edited by pr-codex bot
Loading

Fixes: DASH-333

PR-Codex overview

This PR focuses on enhancing error handling for resolving IPFS URLs by replacing instances of resolveScheme with resolveSchemeWithErrorHandler across various components, ensuring that errors are caught and logged, improving the robustness of the application.

Detailed summary

  • Added resolveSchemeWithErrorHandler to handle errors when resolving IPFS URLs.
  • Replaced resolveScheme calls with resolveSchemeWithErrorHandler in multiple files, including:
    • metadata.tsx
    • contract-info.tsx
    • TeamGeneralSettingsPageUI.tsx
    • ecosystem-header.client.tsx
    • TokenIdPage.tsx
    • wallet-address.tsx
    • chain-icon.tsx
  • Introduced ESLint rules to warn about potential errors when using resolveScheme.
  • Implemented logging for resolution errors in resolveSchemeWithErrorHandler.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 21, 2024 7:39pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 21, 2024 7:39pm
wallet-ui ⬜️ Skipped (Inspect) Oct 21, 2024 7:39pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:05 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc5b543

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 21, 2024 19:05
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 21, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (1a45f21) to head (bc5b543).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5096   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3959     3959           
=======================================
  Hits        24804    24804           
  Misses      29259    29259           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1a45f21
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 442 ms (-5.85% 🔽) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 1.2 s (-0.73% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 115 ms (+190.26% 🔺) 212 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 61 ms (+638.84% 🔺) 71 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 248 ms (+249.72% 🔺) 595 ms

@linear
Copy link

linear bot commented Oct 21, 2024

DASH-333 Fix resolveScheme unhandled errors crashing the page

@MananTank MananTank mentioned this pull request Oct 21, 2024
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank MananTank force-pushed the 10-22-fix_all_resolvescheme_unhandled_errors branch from 2c7e3f7 to bc5b543 Compare October 21, 2024 19:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 19:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 19:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 19:37 Inactive
@graphite-app graphite-app bot merged commit bc5b543 into main Oct 21, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-22-fix_all_resolvescheme_unhandled_errors branch October 21, 2024 19:40
@vercel vercel bot temporarily deployed to Production – docs-v2 October 21, 2024 19:40 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 21, 2024 19:40 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 21, 2024 19:40 Inactive
@MananTank MananTank mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls