Skip to content

Handle published contract page server side errors #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Handle published contract page server side errors #5098

merged 1 commit into from
Oct 21, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 21, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on adding error handling and validation for published contracts in various components of the dashboard application. It introduces checks to ensure that published contracts and versions exist before proceeding with operations.

Detailed summary

  • Added null checks for publishedContracts in multiple files.
  • Introduced notFound() calls when no published contracts or versions are found.
  • Updated publisher address resolution logic to handle errors gracefully.
  • Ensured that published contract versions are fetched correctly with error handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:32pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:32pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:32pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:32pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 002c545

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 20:10 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review October 21, 2024 20:10
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 21, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank force-pushed the 10-22-handle_published_contract_page_server_side_errors branch from 37d5d47 to b068b37 Compare October 21, 2024 20:11
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 21, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 21, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 21, 2024 20:11 Inactive
@MananTank MananTank force-pushed the 10-22-handle_published_contract_page_server_side_errors branch from b068b37 to 945324a Compare October 21, 2024 20:13
@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (bc5b543) to head (002c545).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5098   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3959     3959           
=======================================
  Hits        24804    24804           
  Misses      29259    29259           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bc5b543
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 2.7 s (+6.55% 🔺) 3.6 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 7.1 s (+8.79% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 300 ms (+84.34% 🔺) 396 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 67 ms (-3.28% 🔽) 77 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 564 ms (-22.73% 🔽) 911 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank
Handle published contract page server side errors (#5098)
002c545 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving error handling and null checks in the `published-contract` related components of the dashboard application. It ensures that appropriate actions are taken when data is missing, enhancing the application's robustness.

### Detailed summary
- Added null checks for `publishedContracts` in multiple files.
- Implemented `notFound()` calls when `publishedContractVersions` or `publishedContracts` are missing.
- Enhanced error handling in `getPublishedContractsWithPublisherMapping.ts` with try-catch.
- Updated `publisherAddress` resolution logic for better clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-22-handle_published_contract_page_server_side_errors branch from 945324a to 002c545 Compare October 21, 2024 20:29
@graphite-app graphite-app bot merged commit 002c545 into main Oct 21, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-22-handle_published_contract_page_server_side_errors branch October 21, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls